[BUG] Messages with an ItemHover tooltip do not send on dedicated server when the ItemStack has NBT
Alwinfy opened this issue ยท 1 comments
What happened?
- Messages with an HoverEvent.ShowItem tooltip do not send on dedicated server when the ItemStack has NBT
What should happen?
- The message should appear; instead it does not get sent to clients
Steps to reproduce
- Install Quark and DI-forge (any newer version works)
- Press Shift-T over an item without NBT (e.g. water bucket)
- Press Shift-T over an item with NBT (e.g. enchanted sword)
- Water bucket will share properly, but sword wil lnot
Version
- 1.12
- 1.16
Platform
- Forge
- Spigot
Mod version:
Additional info
- After some debugging, I think this is due to an issue with the Adventure library this uses, specifically here: in more recent versions, NBT tags on items are serialized to complex JSON objects rather than raw strings. I am not certain, however, and more research may be required
Second confirmation on this issue - messages aren't getting sent because your event handler is crashing with a jda exception - "Title may not be empty"
Relevant server log : https://gist.github.com/Shadows-of-Fire/79777ffa1dfbfaa9dc80245bb485e1f1