Debugify

Debugify

Mods
16M Downloads

[Patch Request] MC-185901 - Packets over 2MiB crash clients

AdminHcat opened this issue ยท 3 comments

commented

Mojang Bug Report ID

MC-185901

Bug adhere to the guidelines.

  • I made sure that this bug adheres to the guidelines.

Has not already been requested.

  • I am certain this patch has not already been requested.

Has not already been implemented.

  • I know that this patch isn't already in the latest version of the mod.

Existing implementation

https://github.com/Tfarcenim/XLPackets

image

commented

There is a fundamental issue with this problem. How much data do you want to receive? This mod increases the limit to 2 GIGABYTES PER PACKET. This seems quite large. Maybe increase it to something more reasonable like 10 mebibytes? (increased from 2 mebibytes). Or alternatively, don't kick yourself from the server? Could cause issues with chunks not loading (better than a kick?). I'd like some feedback on this.

commented

Or, maybe this isn't the fault of the client at all and the server should have a better protocol for sending these large packets. (Splitting them up into smaller pieces?)

commented

Going ahead and closing as this is a protocol error, which I can't change and XL Packets is not a viable fix.