Debugify

Debugify

16M Downloads

[Patch Request] MC-237017

bobthehuman opened this issue ยท 6 comments

commented

Mojang Bug Report ID

MC-237017

Mod Loader

N/A

Bug adhere to the guidelines.

  • I made sure that this bug adheres to the guidelines.

Has not already been requested.

  • I am certain this patch has not already been requested.

Has not already been implemented.

  • I know that this patch isn't already in the latest version of the mod.
commented

Potential to breakage of intended behaviour by datapacks.

commented

Please reconsider patching this. I cannot make the datapacks I want because of this bug as the bug itself breaks intended behavior of datapacks

commented

@bobthehuman @TheFantasticLoki Here is a simple one-mixin mod that fixes MC-237017: https://github.com/Andrew6rant/MC-237017-Fix/releases

I'm curious what the potential breakage is, @isXander. I'm no worldgen modder (at all, lol), but it looks to me like I just removed the strangely-hardcoded lava at Y-54 and below.

It shouldn't break datapacks because the only things in createFluidLevelSampler that datapacks can interact with (settings.seaLevel() and settings.defaultFluid()) stay the same between vanilla and my mod)

commented

Fixing this will not break intended datapack behaviour as you can adjust this value via datapacks.
Fixing this would only allow the value to drop below -54 via a datapack and depending on a bug, that Mojang aknowledged to fix in the future, in your datapack, doesn't seem supportable anyway. Also i've never seen anyone depend on this for any reason.

commented

I guess this would be okay to implement as a gameplay fix (which are auto-off).