Decorative Blocks

So, basically, soul particles spawned by Soul Brazier only move in positive X/positive Z directions, without even considering negative X/Y or entire Y axis. This should give a better presentation:

I would make a pull request with fix for this, but it is a simple enough issue that is caused by this single line:

Decorative-Blocks/src/main/java/com/lilypuree/decorative_blocks/blocks/BrazierBlock.java

Line 124 in d90fd0a

    
           worldIn.addParticle(ParticleTypes.SOUL, (double) ((float) pos.getX() + 0.5F), (double) ((float) pos.getY() + 0.8F), (double) ((float) pos.getZ() + 0.5F), (double) (rand.nextFloat() / 10.0F), 5.0E-5D, (double) (rand.nextFloat() / 10.0F));

What that line should look like is something like this:

worldIn.addParticle(ParticleTypes.SOUL, pos.getX() + 0.5, pos.getY() + 0.8, pos.getZ() + 0.5, ((rand.nextDouble()-0.5)/10.0), (rand.nextDouble())/5.0), ((rand.nextDouble()-0.5)/10.0));

...assuming you don't mind getting rid of those weird double-float-double casts which really have no business being there, I would also advise to make the same change to lava particles for original brazier, it shouldn't matter because their velocity doesn't seem to be dependent on what you'd want it to be, but just to keep things organized.

It has been fixed for 1.16.1, and 1.16.2+ will recieve a fix once I finalize the 1.16.1 version so I'll close this issue now.

👌

Share to