Deep Aether

Deep Aether

10M Downloads

Poison Buckets lack Fluidhandler Capability

VoidLeech opened this issue ยท 0 comments

commented

Forge/Neoforge Version

47.4.0, 21.1.119

Deep Aether Version

1.1.7, 1.1.4

Terrablender Version

3.0.0.169, 4.1.0.3

Aether Version

1.5.1, 1.5.8

Log Files

n/a

Bug Report

Since you add a poison fluid, it's expected that buckets of this fluid have a fluidhandler capability, i.e. both on your own as well as adding one to the Aether's skyroot poison bucket. Might be the cause for most if not all of #287

Steps to reproduce:

  1. Query for ForgeCapabilities.FLUID_HANDLER_ITEM/Capabilities.FluidHandler.ITEM on a stack of the Skyroot Poison Bucket or normal Poison bucket.
  2. Call getContainer() on the handler.
  3. Crash because there is no handler (Obviously no sane dev would not check that it's actually present but this is just for the sake of example)

Aether on 1.21.1 already has a SkyrootBucketWrapper (The-Aether-Team/The-Aether#2568) you could use for the Skyroot Poison Bucket, for 1.20.1 you'd probably have to wait on The-Aether-Team/The-Aether#2748,
For your own bucket (Neo)Forge's FluidBucketWrapper should just suffice.