Deep Dungeons

Deep Dungeons

95.3k Downloads

Crash on Fabric 1.16.5

Zano1999 opened this issue ยท 7 comments

commented

It crash on fabric 1.16.5.
Here the log: https://pastebin.com/Mt4XcFX3

commented

I managed to reproduce this by adding an older cloth-config to my mods but... I don't understand why it is happening - deep dungeons provide cloth-config 4.11.14 and some other mod you use provide v4.8.3. In this situation, the Fabric should just load the newer one. For now, you can just download the newest Cloth Config API.

commented

I forced Deep Dungeons to use v4.8.3 by adding it to the jar and editing the fabric.mod.json file - it launched just fine. No idea why it's crashing, so weird.

Why isn't the Fabric Loader loading the newer version of cloth-config if present? Is something enforcing the v4.8.3? (Likely not other mod because I only have a few.) If yes then maybe Deep Dungeons is crashing because it is restricted to the v4.11.14 and it can't launch it?

commented

No Expensive overwrites the entire anvil combination logic method, and it is responsible for this crash. I don't know where the Fabrication dependency is coming from (I assume Cloth?), but it is trying to inject into the same method No Expensive nukes into oblivion. Downgrading Cloth seems to fix the issue because it doesn't pull Fabrication... or something like that.

*Loader might have trouble determining the newer version for Cloth because the package/name of the project changed recently, IIRC. Not sure if that is related.

The best solution to this crash is to remove No Expensive. Thank you for the report!

commented

Ok but why is it crashing for me? I don't have NoExpensive and Fabrication. The only thing I did is adding outdated cloth-config - https://gist.github.com/RDKRACZ/e484e29d883bf72b1f03f30b313d2c31

commented

*Loader might have trouble determining the newer version for Cloth because the package/name of the project changed recently, IIRC. Not sure if that is related.

But the id is still the same, isn't this what is used when fabric is trying to determine mod versions?

commented

Also, uhh if the crash is caused by a "collision" of Fabrication and NoExpensive then why is Deep Dungeons marked as crash-responsible?

commented

Oh, I didn't scroll down enough in the log, sorry. Saw the failed mixin and figured that was it. I'll check this out in a second.

*edit: Hmm, really not sure what is up. Cloth Config recently merged with Auto Config, and the issue is that the version without Auto Config is being loaded from a different dependency (so my mod crashes). I don't know why loader is prioritizing 4.8 over 4.11 here. I'll ask the author of CC if they have any ideas.