Deep Mob Learning: Refabricated

Deep Mob Learning: Refabricated

3M Downloads

Partial Incompatibility with MC Dungeons Weapons

chronosacaria opened this issue ยท 9 comments

commented

Hi NathanPB,

I hope that you are well.

I got a report of some issues of some of my crossbows not working in certain modpacks and I was finally able to narrow down the issue to DML-Refabricated. However, I am not 100% why. I did notice that there is a mixin related to crossbow reloading. If you want to test it out, you can load both of our mods together and try to shoot the Corrupted Crossbow, for example. It will have the loading animation, but will not actually load a bolt.

Please let me know if there is anything that I can do on my end.

Take care!
chronosacaria

commented

Hey, thanks for reaching me. I will check this up later, running a bit low on time lately.

I do have a (very cursed) mixin on crossbows to make it load faster, sure this is the problem. I will try to test this out when I have some time

commented

Thank you, so much, mate! And thanks for such a quick response!

commented

@chronosacaria what do those crossbows that are not working have in special?

commented

That is the weird part, I couldn't find anything in common with them. I really don't know why it was these in particular. I know that it can't be arbitrary but it sure feels that way, ya know?

commented

Do you have your mod published anywhere that I could import on gradle? I'm still now sure how to use the curseforge's maven thing

commented

Crossbows that have 24f or less of draw speed are the ones that the bug occurs, I will keep investigating to figure out why

commented

Sorry, I just saw these. I'm on vacation, so my response time is a bit delayed. As far as publishing, apart from on GitHub I've not got it published anywhere because I honestly don't understand how the whole maven thing works yet. I didn't realise that it was the draw speed. Thank you for catching that

commented

Hey @NathanPB! I know that it has been a while, but we might have been able to get this issue resolved? Kluzzio has taken a look at the mixin and was able to change the second @ModifyVariable to a @ModifyArg and we were able to get the crossbows shooting again whilst everything else appeared to work still. Kluzzio will be submitting what they did as a PR so you can take a look at it. Please let us know if this is something that works as I would love to see this issue resolved.

commented

@chronosacaria sure, I received the PR, I'm just checking some stuff before getting this merged