Chunk loading issue
Devilswarchild opened this issue ยท 18 comments
Mod Version: deeperdarker-forge-1.20.1-1.2.0.jar
Mod Loader: forge 47.1.3
MC version 1.20.1
Description:
biomes in the insideout dimensions are not rendering properly and when spawning the sculk snapper game sometimes crashes or doesn't. but its evidently clear something has broken with the transition to 1.20.x.
To Reproduce:
Steps to reproduce the behavior:
- Go to insideout dimension and try to go over a couple hundred blocks in any given direction
- see error and all associated ticks (just halts)
Screenshots:
Additional context:
here logs from two of my dev members for my modpack MineColonies: Dimensional Adventure
(Hitherix) debug.log (https://mclo.gs/ZSWu1Xm for easier reading)
(Hitherix) latest.log (https://mclo.gs/Y0FqqMa for easier reading)
(SeantheSheep) debug.log (https://mclo.gs/R6fSmEh for easier reading)
(seanthesheep) latest.log (https://mclo.gs/mrs2l8C for easier reading)
(seanthesheep)launcher_log.txt (https://mclo.gs/ipxueg1 for easier reading)
Chunk loading is a known issue, but no one in the dev team, including me, don't really know what's causing it. We are still trying to find the cause
my main dev member says its something in the forest related biome of your mods dimension finding an entity it just doesnt like
cause he says as soon as whatever mob it is spawns the ticks just stop updating
nope its not entities causing it. We've tested on peaceful and it was still an issue. All we know is that its being caused by features (things that generate like vines, trees, ores, etc)
Oops! Did not even realize. Chunk loading is still an issue however.
same seed, same place
Not the column-loop issue, but the chunks-not-generating issue. Even with the infinite loop prevention, the chunks still refuse to load on forge.
Oh I see ok. Just be absolutely sure the 2 aren't related because chunks failed to load on fabric as well because it got stuck in an infinite loop of trying to load them when it hit the column segment.
If it's a separate issue it should be relatively trivial to debug as well by pausing in debug mode when it happens. Unless it's not an issue with an infinite loop or deadlock which can be harder to solve.
Yep there is an issue with the commit u made to the forge version: a1eeb84?diff=split#r129754652
I've flown out 10000 blocks north with that seed and no issues at all. I didn't update the Forge version so maybe that's why?
It looks like the column feature is failing to generate. Specifically the stretchToFloor feature method. That's the only common link I could find between the 2 debug logs sent.
I wonder if it's stuck in an infinite loop trying to generate it because something changed in 1.20 that modified how stretchToFloor is called?
Yep this is the issue. Been debugging and the issue is it can exit the bottom of the world if it doesn't find specified block within the if statement. You need to check for bedrock placement as well or check if y > 0 for lower placement and the opposite for upper.
You can see y = - (a very big number) here in the screenshot
5e4f20e does not seem to fix the issue.
load a world on this seed: -1125972046644107959
then go north
The chunk loading is not an issue on fabric, but it is on forge. It's not the columns that cause the issue
The chunk loading is not an issue on fabric, but it is on forge. It's not the columns that cause the issue
Really? I mean based on that debug trace it absolutely should be an issue for both platforms, it's an infinite loop.
It also stopped loading chunks on fabric when I tested it so it's definitely not a Forge only issue.
Tbh structures are very rarely platform specific as well so the chances it's a Forge only issue is incredibly low.
Not the column-loop issue, but the chunks-not-generating issue. Even with the infinite loop prevention, the chunks still refuse to load on forge.