Minecraft Version

1.20.x

Mod Loader Version

0.14.22

Mod Version

1.3.4

Describe the Issue

I noticed that the thirst effect chance cannot be edited for water in glass bottles. In the config file I was able to tweak the "flask_dirty_thirst_chance" and the "water_sip_thirst_chance", so I changed them both to 0.10 to drop the Thirst Effect chance down to 10%. However, I notice that whenever I take a sip of 'dirty' water from a glass bottle, the Thirst Effect chance is still incredibly high, so much so that I get the effect whenever I drink out of one. Shouldn't it also be a 10% chance like everything else?

It doesn't appear that there is a way to adjust Thirst Chance for glass bottles. Am I missing something, or can this be fixed?

Thank you for your help!

latest.log

Wasn't able to provide log right now.

Do you use any other mods except the required ones?

Yes, but I tested the issue without any of the other mods installed and it was still happening.

Hello! Thank you for your response. Actually I have tested this mod in both 1.20.1 and 1.19.2 and it seems like the "potion_bad_thirst_chance" option doesn't really change anything. I get the thirst effect any time I drink dirty water out of a glass water bottle, regardless of the number I set in the config.

P.S. I noticed that you added this as an issue priority on January 1st, so it looks like it's going to get fixed! If you do fix it, please consider fixing it for the Minecraft 1.19.2 version too since I have downgraded to that version for the modpack I'm working on. Thank you! 😊😊

Since the water bottle is a potion item and has bad water in it, the chance is set via the potion_bad_thirst_chance config option.