Demagnetize

Demagnetize

8M Downloads

Whitelist and blacklist not working when using Botania’s ring of magnetization

Dimentive opened this issue · 10 comments

commented

I want the demagnetizer to only prevent me from picking up canola seeds, crystallized canola seeds, and empowered canola seeds from Actually Additions. I’m using an advanced demagnetizer. I’m not sure whether to put it on whitelist or blacklist (for instance, does “whitelist” mean “only stop magnetizing for the selected items” or “keep these items from being affected from the demagnetization”? I assume it’s the former), but I’ve tried both whitelist and blacklist, and I’ve configured it to only affect these three types of canola seeds, but the demagnetizer keeps any items from being magnetized in its vicinity regardless.

Demagnetizer bug

  • Modpack: Enigmatica 2 (version 1.63a)
  • Minecraft: 1.12.2 (duh)
  • Forge: 14.23.5.2781
  • Demagnetize: 1.0.1 (latest)
commented

What magnet are you using with it? Your configuration seems to be correct, as "Whitelist" does mean "only demagnetise these items".

commented

I am using the ring of magnetization from Botania.

I thought that the ring was broken at first, but it turns out it was the demagnetizer causing it to stop functioning in its vicinity. My ring of magnetization doesn’t magnetize any items while I’m near the demagnetizer.

This could still be an issue on Botania’s side; I’m not sure.

I’m using version r1.10-361 (latest) of Botania.

commented

Yeah, that's an issue with how I implemented the Botania compatibility. My mod just emulates a Solegnolia, which doesn't have an item filter, so the item filter is ignored.

I've been intending to fix this for quite a while (see #1) but never got around to it. I'll submit a PR to Botania today to make it directly compatible, so my Solegnolia emulation won't be needed.

commented

I've submitted a PR to Botania at VazkiiMods/Botania#2888.

When it has been merged and a build of Botania is published with the fix in it, I'll release a version of my mod that disables the explicit Botania compatibility when that build (or newer) of Botania is detected. This will also fix #1.

commented

Awesome! Thanks! 🙌

commented

Disable the Botania compatibility? Do you mean this won’t be fixed?

commented

No, I mean disable the setting in my mod for "Botania compatibility" because Botania has directly implemented checking of the NBT tag that my mod adds, so the explicit compatibility method (that ignores the whitelist) isn't needed. For now, once you have updated Botania to a build including my changes, it will continue to work the same way as before until you disable the setting in my mod for explicit compatibility with Botania.

commented

Once the build of Botania is released, you just need to go into my mod's config and disable the Botania compatibility to fix this behaviour.

When I get some free time, I'll put in some logic to turn it off by default when a new enough build of Botania is detected (or just regardless of Botania version, because if you have my mod updated you probably have Botania updated anyway). I have some other things I want to fix in my mod as well (#7, config syncing to client, and a bit of code cleanup), so I'll do all of that soon.

commented

All right, I understand. I’ll be doing that once the new version of Botania is released. Thanks again for the PR!

commented

Fixed by e79c22f, released in 1.12.2-1.1.0 (edit: now approved!)