Destroy

Destroy

110k Downloads

Compatibility problem with Create: Metallurgy

Fouriceeee opened this issue · 2 comments

commented

Describe the bug
If you add only Create: Metallurgy to your Minecraft, you can use your wrench to rightclick the Foundry Basin(a machine from Create: Metallurgy) to create a spout like a Basin from Create.
If you add Destroy and Create: Metallurgy to your Minecraft at the same time, rightclicking the Foundry Basin with your wrench doesn't work any more.
Plus, just adding Petrolpark will not lead to such a compatibility problem. This problem just occurs when Destroy and Create: Metallurgy exist at the same time.

Image

System Information

  • Minecraft 1.20.1/ Forge 47.4.0
  • Create version 0.5.1j
  • Destroy 0.1.1
  • Petrolpark 1.4.2
  • Create: Metallurgy 0.0.7
  • JEI 15.20.0.106

Additional context
In my modpack, I write the following Kubejs Code to deal with this problem:

BlockEvents.rightClicked('createmetallurgy:foundry_basin', event => {
    if(event.item === 'create:wrench' && !event.player.isShiftKeyDown()) {
    let face = event.facing
    let blockState = event.block.blockState
    let pos = event.block.pos

    if(face.axis.isVertical()) return

    if(face === blockState.getValue(BlockProperties.FACING_HOPPER)) face = Direction.DOWN

    let state = blockState.setValue(BlockProperties.FACING_HOPPER, face)
    event.level.setBlockAndUpdate(pos, state)
    event.cancel()
    }
})

¯_(ツ)_/¯
This problem troubled me for a long time until I tried to learn KubeJS.

commented

Hey 👋
Create Metallurgy author here! Since @Fouriceeee open an issue on my repo. I came to the conclusion that is might caused by one of your mixin injection, Since my Foundry Basin depending on the Create Basin.

If you want any further informations, you can contact me on my discord :D

commented

Destroy's mixins are quite ham handed. I can probably replace with a MixinExtras mixin.