Diet (Fabric/Forge/Quilt)

Diet (Fabric/Forge/Quilt)

6M Downloads

[Bug]: DietValueGenerator causing watchdog to kill server upon starting due to massive time consumption on large modpack.

OddBirdStanley opened this issue · 2 comments

commented

What happened?

Apparently, DietValueGenerator takes more than 180 seconds to find recipes for ~2000 items, killing the server thread within a tick. While a large time consumption may be inevitable, the process should take place at some point before the server starts or be executed in a way that does not alert the watchdog.

How do you trigger this bug?

Have 360 mods.

Forge Version

Forge 36.2.8

Mod Version

Diet 1.16.5-1.0.0

Other Relevant Mod Versions

Relevant Log Outputs

No response

commented

Unfortunately, starting this process before the server initializes is not possible because it requires information from tags loaded by datapacks from the server.

Would there be any issue if you changed the server.properties so that the max-tick-time was a larger value, or -1 to disable the watchdog altogether?

commented

Yes, that would be viable. Although, an integrated server does not have a config. I’m thinking about writing something that disables the feature. Thanks for your timely response.