DimensionalDoors

DimensionalDoors

Mods
12M Downloads

[Bug]: Custom ArgumentTypes incorrectly use `minecraft` namespace

unilock opened this issue ยท 0 comments

commented

What happened?

DimDoors/common/src/main/java/org/dimdev/dimdoors/mixin/ArgumentTypesMixin.java

Lines 23 to 27 in 866a668

@Inject(method = "bootstrap", at = @At("RETURN"))
private static void register(Registry<ArgumentTypeInfo<?, ?>> registry, CallbackInfoReturnable<ArgumentTypeInfo<?, ?>> ci) {
register(registry, "pocket", PocketTemplateArgumentType.class, SingletonArgumentInfo.contextFree(PocketTemplateArgumentType::new));
register(registry, "block_placement_type", BlockPlacementTypeArgumentType.class, SingletonArgumentInfo.contextFree(BlockPlacementTypeArgumentType::blockPlacementType));
}

The code here registers Dimensional Doors' ArgumentTypes with the minecraft namespace (since it doesn't specify its own), which causes issues when connecting to a dedicated server running behind a Velocity proxy, as CrossStitch doesn't know to wrap the ArgumentType so Velocity doesn't complain.

Mod Version

5.3.3-fabric

What versions of Minecraft does this issue happen on?

No response

Log

No response