Incompatibility with Real Camera
Steveplays28 opened this issue · 5 comments
Describe the issue
Using Do a Barrel Roll with Real Camera causes a crash when joining a multiplayer server (server doesn't have the mod, but I doubt that's relevant for this specific crash).
Crash report/logs
https://mclo.gs/63Oa1bw
Additional information
N/A
Real Camera is probably doing some cursed as hell shenanigans, cause I have no idea what could be causing this crash. You may have a better time asking their side for compatibility.
While I'd be happy to make required changes if given an explanation of the problem, I'm not going to invest more time into figuring this out myself. Feel free to reopen if you get more information in the future.
Thanks for getting back!
I took a look, it seems like mixin is thinking you want to update the shadow tickDelta
field in the actual class (even though this is not explicitly specified using @Shadow
) instead of the local tickDelta
field you made:
I think renaming the field to doABarrelRoll$tickDelta
would fix the issue, haven't tested though.
The actual issue probably stems from the fact that the PlayerEntityRenderer#setupTransforms
method is called from somewhere inside Real Camera's code, instead of in MC's code (which I'm guessing is in a constructor somewhere).
Oh I should definitely fix that mixin yea, I probably made that before I actually knew how to do em properly. I don't quite see how that'd cause issues though, since PlayerEntityRenderer
doesnt have a tickDelta
field?
Changing that mixin did in fact fix the issue! I'll push an update soon™, thanks for helping figure this out.
Awesome, no problem.
Thank you as well for trying that.
Oh I should definitely fix that mixin yea, I probably made that before I actually knew how to do em properly. I don't quite see how that'd cause issues though, since PlayerEntityRenderer doesnt have a tickDelta field?
Weird, it probably should since the class is for rendering. Definitely has to do with Real Camera moving the setupTransforms
call though.