Do a Barrel Roll

Do a Barrel Roll

8M Downloads

Controlify binding initialization fails due to controlify renaming onControlifyPreInit() -> onControlifyInit()

villevilli opened this issue ยท 1 comments

commented

Describe the issue

Controlify binding initialization fails due to controlify renaming onControlifyPreInit() -> onControlifyInit() Which causes controller bindings to revert back to being emulated keyboard buttons.

Relevant change on controlify

isXander/Controlify@ff0dfb1#diff-2f0f6a8cf59f14a8668d2cd141979978637bd27130fffc41ff344cb3f2e203adR19-R28

Crash report/logs (if applicable)

Full log

https://mclo.gs/ZR9jj4X

Relevant Snippet

[21:47:44] [Render thread/ERROR]: Failed to run `onControlifyInit` on Controlify entrypoint: nl.enjarai.doabarrelroll.compat.controlify.ControlifyCompat
java.lang.AbstractMethodError: Receiver class nl.enjarai.doabarrelroll.compat.controlify.ControlifyCompat does not define or inherit an implementation of the resolved method 'abstract void onControlifyInit(dev.isxander.controlify.api.entrypoint.InitContext)' of interface dev.isxander.controlify.api.entrypoint.ControlifyEntrypoint.
	at knot/dev.isxander.controlify.Controlify.lambda$initializeControlify$17(Controlify.java:255) ~[controlify-2.4.1+1.21.8-fabric.jar:?]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
	at knot/dev.isxander.controlify.platform.main.fabric.FabricPlatformMainImpl.applyToControlifyEntrypoint(FabricPlatformMainImpl.java:45) ~[controlify-2.4.1+1.21.8-fabric.jar:?]
	at knot/dev.isxander.controlify.platform.main.PlatformMainUtil.applyToControlifyEntrypoint(PlatformMainUtil.java:38) ~[controlify-2.4.1+1.21.8-fabric.jar:?]
	at knot/dev.isxander.controlify.Controlify.initializeControlify(Controlify.java:253) ~[controlify-2.4.1+1.21.8-fabric.jar:?]
	at knot/net.minecraft.class_310.handler$zzh000$controlify$initControlifyNow(class_310.java:3131) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_51736(class_310.java:765) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_53465(class_310.java:750) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_29338(class_310.java:731) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_156.method_17974(class_156.java:677) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_53522(class_310.java:726) ~[client-intermediary.jar:?]
	at knot/net.minecraft.class_425.method_25394(class_425.java:131) [client-intermediary.jar:?]
	at knot/net.minecraft.class_757.method_3192(class_757.java:538) [client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1523(class_310.java:1361) [client-intermediary.jar:?]
	at knot/net.minecraft.class_310.method_1514(class_310.java:947) [client-intermediary.jar:?]
	at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:506) [fabric-loader-0.17.2.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:72) [fabric-loader-0.17.2.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.17.2.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]

Additional information

The issue seems to be related to the new method (onControllerInit) missing on the class, as the old method is only deprecated renaming the method will probably fix the issue.

commented

I'll go ahead, and try to type up a pr to hopefully fix this (: