Doggy Talents

Doggy Talents

27M Downloads

Client disconnects when assigning bed to dog on server

firelightxi opened this issue ยท 8 comments

commented

Environment And Mod Information:

  • Minecraft Version: 1.16.3
  • Forge Version: 34.1.18
  • Doggy Talents Version: 2.0.0.3
  • Java Version: [8 Update 261 64 bit]
  • Operating System (OS): [Ubuntu 20.04.1 LTS]

Logs

Issue Description:

Client disconnects when assigning a bed to a dog on a server. Client message:
Internal Exception: io.netty.handler.codec.DecoderException: net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: minecraft:

Steps to reproduce:

  1. Set up a forge server 34.1.18 with the mod
  2. Have client connect to the server and tame a wolf, and give the wolf a training treat
  3. Place down a dog bed, and right-click on the dog bed
  4. Let the dog navigate to the dog bed

Additional Information:

  • More Details:
    No crash happens, only client disconnection
    Trying to reconnect to the server causes it to show the same message over again
    This error does not happen in single player or when hosting as LAN

  • Screenshots:
    Screenshot from 2020-10-11 23-41-22

commented

I think this might be related to the order in which the DataParameters are initialised, sometimes they are initialised in different orders on the client and server causing mismatched data sync ids.

Since this is a difficult one to test once I make a 'fix' can you test and let me if that was the cause..

commented

Yeah, I can test out the fix once it's rolled out!

commented

Possible fix is released in 2.0.0.4

commented

I tested it out, it still seems to disconnect the client from the server with the same message. After some further testing, this also occurs with the food bowl as well.

commented

Ahh silly me, I just had commented out some code when updating to 1.16 BedLocationsSerializer.java#L35

commented

I have released the fix in 2.0.0.5, this should be it this time. Some feedback again would still be appreciated thanks and then I will close the issue.

commented

Yup, the bug seems to be fixed in 2.0.0.5! Can confirm it works for both the bed and the food bowl.

commented

Awesome, closing issue!