Doggy Talents

Doggy Talents

Mods
27M Downloads

Revive incompatibility with RandomPatches MC-2025 fix

TheRandomLabs opened this issue · 3 comments

commented
  • Minecraft Version: 1.16.1
  • Forge Version: 36.0.1
  • Doggy Talents Version: 1.16.4-2.0.1.2
  • Java Version: GraalVM 11.0.9
  • Operating System (OS): Windows 10 64-bit Build 19042.746

Issue Description:

RandomPatches' fix for MC-2025 works by serializing entity bounding boxes. When Doggy Talents revives a dog, it sets the position, but it does not recalculate the bounding box for the new position. The simplest fix I can see is would be to call setPosition here after read, which would automatically recalculate the bounding box.

Steps to reproduce:

  1. Revive a dog.
commented

I don't know much about RandomPatches, some quick research the bug MC-2025 into it it seems like an issue with reloading existing mobs into a world. Is there an explict issue you are experiencing?

To combat any potential issue I have flipped the 7th param to true which on the spawn method so that setPosition is called in
net.minecraft.entity.EntityType

L337: if (p_220349_7_) {
L338:    t.setPosition((double)pos.getX() + 0.5D, (double)(pos.getY() + 1), (double)pos.getZ() + 0.5D);
L339:    d0 = func_208051_a(worldIn, pos, p_220349_8_, t.getBoundingBox());
L340: } ....
commented

Here is a brief description.
Thank you! 😄

commented

Released in 2.0.1.3