Doggy Talents

Doggy Talents

27M Downloads

Dog Health Increases Not Persistent

esotericist opened this issue ยท 7 comments

commented

I noticed that each time you level the dog, it gains some max HP. This doesn't seem to be persistent, however... when saving then loading the game, their health is set back to their base of 20 HP until they are given another treat to increase their level.

This also appears to happen if you use something like exu2's golden lasso to pick up or put down the dog.

Looking at the NBT data, it looks like you're editing the max HP attribute directly, rather than adding a separate attribute or effect to increase the maximum health. I think the latter might be more robust, but failing that, updating the max HP whenever, say, the menu is accessed might mitigate this.

This is on Doggy Talents 1.11.2-v1.12.2a, with forge 2388.

commented

Well, I certainly can't dispute that it works, considering the working versions of the mod you've got posted. :D

While I'm here, thanks so much for this mod. I've been needing a nice combat pet for a while (especially since I can't have golems anymore), and that it doubles as so much utility is awesome. Wolf mount is best.

commented

I think you are correct, I should be adding a separate attribute. It is the same for the MOVEMENT_SPEED attribute I should be adding a separate attribute as well. I didn't adapt very well when these changes came into MC. Once I have finished creating a universal version that works on MC 1.9.4 through to MC 1.12 I will be looking at lots of bug fixes. (I am close to finishing maybe 1 more day)

commented

Glad to hear. I wish I could help, but I'm not very comfortable with java, and your compilation method seems a little non-standard.

commented

Yes it is a bit, my method is far from perfect and probably not the only way / best way. But I came up with it and it works so Im happy :)

commented

Nope, upon loading the world the max health will be set correctly.

commented

Is there anything in particular we'll need to do to fix the health for our dogs once this is released?

commented

Awesome to hear.