Question - When can we put armor on dogs?
Hyro258 opened this issue ยท 7 comments
You can now if you want, directly right-click the dog with an armor item in your hand to wear it on the dog, but keep in mind that currently enchantments ARE NOT SUPPORTED, so any enchantments will be ignored (i tested with Frost Walker, Protections), and also you still have to use the collar scissor to unequip them which is counter-intuitive because it would be pretty annoying when you want to swap armors due to you having to recollect all of the accessories and apply it one by one and the chance that you may accidentally UNTAME your dog. So I would not recommend using it..... instead, I would Level up GuardDog and cross my finger when the dog takes damage ............
I agree it is not ideal, do note that the doggy shears have a 2.5 second cooldown after removing the accessories so you are unlikely to untame the dog
Oh. wait, thats not their feature? Is that a Vtweaks thing? they let you armor the dog with just typical armor pieces other than... leggings I think it was. hat, chest and boots all add to the dog's defense. unsure of it carrying the enchants or how to take it off afterwards with said feature. but it's a thing that can be accomplished...
Well, recently i have been playing around with the source code for a while and basically accompilished some goals (i am still a beginner to modding), and managed to add enchaments to armor with accessories, i utilized the vanilla entity armor system which will equip the dog's super class LivingEnitity Armor Slots every time init() is called and remove everytime remove() is called , it was working great but ....... if an armoritems inside the accessory breaks and the Accessory tries to remove itselft while marking the accessories list dirty, ConcurrentModificationException is thrown, which crash the game due the the DogEntity::MarkDataparameterDirty() method recalculate the alterations arraylist while being called inside the foreach. A workaround is to only call remove, and set a flag after the foreach to indicate if the arraylist need recalc or not ...... wonder if it is optimal ......
Hey, thanks for taking the time to create this issue and I'm sorry I didn't get round to resolving it. I've not worked on this project for a while and have decided to archive the git repository. Fear not, there is a fork https://github.com/DashieDev/DoggyTalentsNext which might be of interest. I don't expect to be back within the Minecraft community so farewell and happy mining!