Doggy Talents

Doggy Talents

27M Downloads

[1.12.1] Crash with new CraftTweaker

b0bst3r opened this issue ยท 8 comments

commented

Environment And Mod Information:

  • Minecraft Version: 1.12.1
  • Forge Version: 1.12.1-14.22.0.2467
  • Doggy Talents Version: 1.14.2.298
  • Java Version, Build, and Byte Type: Version 8 Update 144 64 bit
  • OS Name, Edition, Byte Type, and Build Version: Linux dedicated server

Logs

Crash Log - http://pastebin.ubuntu.com/25473086/

Issue Description:

I know this is caused by the updated CraftTweaker as it works fine with the older 4.0.3 version of CT. Something changed in the updated version which is causing the crash, is this something you need to adjust or do I need to report this to CT?

Steps to reproduce:

  1. Run Doggy Talents 1.14.2.298 with CraftTweaker 2-1.12-4.0.4.jar in a SMP server
  2. Crashes on startup with the above log
commented

Oh I should add the crash only occurs on SMP server, SSP startup seems fine.

commented

Yes it works fine without CT and works with CT 4.0.3 something changed in CT 4.0.4 that broke it.

commented

Hm.. you might want to send this to CT, just in case a change on their side might fix it

commented

Hm, it seems that the function for the item dyes doesn't play kindly with CraftTweaker. Have you attempted this without CraftTweaker?

Here is where it doesn't like the method

   java.lang.NoSuchMethodError: net.minecraft.item.EnumDyeColor.func_193350_e()I
       at doggytalents.base.f.ItemWoolCollarWrapper.func_150895_a(ItemWoolCollarWrapper.java:42)
commented

well you are calling client only code in a universal method... Just because it is never called on the serverside on it's own (Forge + this mod), doesn't mean that you can just ignore sidedness.

TL;DR There is nothing for Crafttweaker to fix

commented

Ah ok, I'll pass on the message to @ProPercivalalb, he knows his way around the code more than I.. I just recently started helping him add to Doggy Talents

commented

I'm catching the same error aswell. I got in touch with @ProPercivalalb and he's still having PC trouble unfortunately.

commented

I believe 'getSubItems' only recently became universal, it use to be only client side. Since I have to focus on multiple versions I forget to change the code for 1.12. Anyway it is fixed now. Fix will be available when I release another version.