Domestication Innovation

Domestication Innovation

2M Downloads

[1.7.1-1.20.1] [Item Deletion Bug] Collar Tags PERMANENTLY delete themselves for no reason when Callable Horses hotkey is pressed

TBlazeWarriorT opened this issue ยท 1 comments

commented

Version:
domesticationinnovation-1.7.1-1.20.1.jar
citadel-2.4.9-1.20.1.jar

The bug:
When I call my horse using the Callable Horses mod while holding a Collar Tag, the tag deletes itself. Very frustrating, has caused me to delete a bunch of tags by accident and lose progress.

Reproducing:
Using DomesticationInnovation and Callable Horses (callablehorses-1.20.1-1.3.0.1.jar):

  • Hold a Collar Tag in any game mode except Creative, even in spectator mode
  • Call your horse
  • One Tag will be bugged out and deleted on each press :(

Video demonstration:

dom.inno.bug.compressed.mp4

MC Logs:
https://api.paste.ee/p/jFVZE

What I know so far:
This has to do with isAreaProtected() from Callable Horses, fakeHorse from Callable Horses, and something stinky I can't figure out with Collar Tags from this mod. The collar is likely being applied to the fake horse entity and being deleted, if not deleted entirely for no reason. What I can't figure out why, is why holding a tag triggers Callable Horses' area protection, and why calling a horse would even attempt to apply that tag to the fake horse, if that's even what's happening. My brian hurts and my tags are missing

commented

I've recompiled the Callable Horses and confirmed that removing isAreaProtected() check stops the collar from being deleted. I'll be using the mod without the area protection for now, whatever it was for, as it can delete items.

Although, it doesn't seem to delete vanilla items, this mod recognizes the fakeHorse from the other mod as a valid horse, and wastes a Collar Tag on the fakeHorse even in spectator mode, so this issue will remain open as neither of the mods have the required safety checks, causing this situation.