Domestication Innovation

Domestication Innovation

Mods
6M Downloads

attacking other players

saviourom opened this issue ยท 4 comments

commented

Cannot attack other players without holding shift when using hardcore revive mod and epic fight. 1.20.1

commented

I don't have those mods and experience the same problem.

The only thing context I have is that we're in the same /team

commented

After peeking around in the code, i can confirm this behavior is hardcoded and intended. As there's no config for it.

DomesticationInnovation/src/main/java/com/github/alexthe668/domesticationinnovation/server/CommonProxy.java

Lines 712 to 723 in 7b0fd34

@SubscribeEvent
public void onLivingDamage(LivingDamageEvent event) {
if(TameableUtils.isTamed(event.getEntity()) && event.getSource().getDirectEntity() instanceof Player player && TameableUtils.isPetOf(player, event.getEntity()) && !player.isShiftKeyDown()){
event.setCanceled(true);
}
if (event.getSource().getEntity() instanceof LivingEntity && TameableUtils.isTamed(event.getSource().getEntity())) {
LivingEntity pet = (LivingEntity) event.getSource().getEntity();
if (TameableUtils.hasEnchant(pet, DIEnchantmentRegistry.IMMATURITY_CURSE)) {
event.setAmount((float) Math.ceil(event.getAmount() * 0.7F));
}
}
}

commented

Definitely not intended. The player cannot be tamed

commented

Yes and no, There's a mixin that changes the return value of isAlliedTo, and that's used by isPetOf. Intended or not - does not really matter. But I wish this was not the case.

I forked the project and made a commit that is a very band-aid solution but it should work in theory.
f5f5a98