
Certain shaderpacks make blocks made with bricks look like they have holes in them
superkiiisa opened this issue ยท 1 comments
Mod version: 1.20.1-1.0.186-RELEASE-universal
Oculus for shaders.
I added DO (as a requirement for Minecolonies) to the modpack I'm currently playing with (https://www.curseforge.com/minecraft/modpacks/steam-punk), along with some other mods not originally present in it (the full list is at the end of this post). The issue below does NOT happen when I launch a completely new version of Minecraft that only has the mod itself, Oculus, and Embeddium.
The issue happens with stone bricks, mossy stone bricks, endstone bricks, and regular brick blocks. Maybe with some other materials too, but the majority of blocks, such as logs, wood, stone/cobblestone, planks and so on work well for all crafted block variants. Aside from having transparent holes (or single coloured surfaces), the blocks appear to have distorted textures (as if the existing texture had been made twice as small):
It even persists in the cutter's GUI:
I looked through the list of mods from that modpack and I don't know what could be causing this problem. I tried removing some mods -- specifically, Transparent (https://www.curseforge.com/minecraft/mc-mods/transparent) and Entity Texture Features (https://www.curseforge.com/minecraft/mc-mods/entity-texture-features-fabric) -- that affected the game textures. They ended up not being the cause of the problem.
I'm not sure if this issue can be fixed by removing any other mods or changing the shader settings (the ones I use have default settings with presets for low-quality to improve game performance, I didn't change anything else). If there's anything else I can try to help debugging, please let me know.
My list of mods:
adtetra-2.0.0
AdvancementPlaques-1.20.1-forge-1.6.7
ad_astra-forge-1.20.1-1.15.18
aeroblender-1.20.1-1.0.1-neoforge
aether-1.20.1-1.5.0-neoforge
aetheric_tetranomicon-1.1.2-1.20.1
aether_delight_1.0.0_forge_1.20.1
aether_enhanced_extinguishing-1.20.1-1.0.0-neoforge
alexscaves-2.0.2
alexsdelight-1.5
alexsmobs-1.22.9
alternate_current-mc1.20-1.7.0
amendments-1.20-1.2.12
aquamirae-6.API15
architectury-9.2.14-forge
ars_elemental-1.20.1-0.6.7.5
ars_nouveau-1.20.1-4.12.4-all
ars_technica-1.20.1-1.3.1
art_of_forging-1.8.3-1.20.1
ash_api-forge-3.0.2+1.20.1
athena-forge-1.20.1-3.1.2
AutoLeveling-1.20-1.19b
automobility-0.4.2+1.20.1-forge
azurelib-neo-1.20.1-2.0.39
balm-forge-1.20.1-7.3.9-all
BarteringStation-v8.0.0-1.20.1-Forge
bclib-3.0.14
bellsandwhistles-0.4.3-1.20.x
better-end-4.0.11
BetterAdvancements-Forge-1.20.1-0.4.2.10
BetterCompatibilityChecker-forge-4.0.8+mc1.20.1
betterfpsdist-1.20.1-6.0
BetterModsButton-v8.0.2-1.20.1-Forge
BHMenu-Forge-1.20.1-2.4.2
biomemusic-1.20.1-2.5
BiomesOPlenty-forge-1.20.1-19.0.0.91
blockui-1.20.1-1.0.186-beta
blue_skies-1.20.1-1.3.31
BoatBreakFix-Universal-1.0.2
BOMD-Forge-1.20.1-1.1.2
Bookshelf-Forge-1.20.1-20.2.13
botarium-forge-1.20.1-2.3.4
Bountiful-6.0.3+1.20.1-forge
BrewinAndChewin-1.20.1-3.1.2
caelus-forge-3.2.0+1.20.1
carryon-forge-1.20.1-2.1.2.7
cc-tweaked-1.20.1-forge-1.113.1
cccbridge-mc1.20.1-forge-1.6.3
CerbonsAPI-Forge-1.20.1-1.1.0
charmofundying-forge-6.5.0+1.20.1
chefs-delight-1.0.3-forge-1.20.1
chipped-forge-1.20.1-3.0.7
citadel-2.6.0-1.20.1
clientcrafting-1.20.1-1.8
cloth-config-11.1.136-forge
Clumps-forge-1.20.1-12.0.0.4
cobweb-forge-1.20.1-1.0.0
ColdSweat-2.3.7
collective-1.20.1-7.91
comforts-forge-6.4.0+1.20.1
CommonCapabilities-1.20.1-2.9.4
ConfiguredDefaults-v8.0.1-1.20.1-Forge
connectivity-1.20.1-5.6
Connector-1.0.0-beta.46+1.20.1
ConnectorExtras-1.11.2+1.20.1
Controlling-forge-1.20.1-12.0.2
copycats-2.1.4+mc.1.20.1-forge
coroutil-forge-1.20.1-1.3.7
cp_tweaks-forge-1.20.1-1.0.21
crashexploitfixer-forge-1.1.0+1.20.1
crawlondemand-1.20.x-1.0.0
create-1.20.1-0.5.1.j
create-cobblestone-deepslate-generators-1.4.1+1.20.1
Create-DnDesire-1.20.1-0.1b.Release-Early-Dev
create-new-age-forge-1.20.1-1.1.2
createair-1.0-1.20.1
createcobblestone-1.4.3+forge-1.20.1-87
createdeco-2.0.2-1.20.1-forge
createmetallurgy-0.0.6-1.20.1
createoreexcavation-1.20-1.5.3
createrailwaysnavigator-forge-1.20.1-0.6.0
createtaczauto-1.3.7-forge-1.20.1
create_ad_astra_compat-forge-1.20.1-1.0.0
create_blue_skies_compat-forge-1.20.1-1.0.1
create_central_kitchen-1.20.1-for-create-0.5.1.f-1.3.12
create_compressed_1.0.1_forge_1.20.1
create_connected-0.9.2-mc1.20.1-all
create_copper_and_zinc-1.6.0-forge-1.20.1
create_easy_structures-0.1.2-forge-1.20.1
create_enchantment_industry-1.20.1-for-create-0.5.1.f-1.2.9.d
Crystal-Clear-2.1-Beta-forge
culturaldelights-0.16.2
cupboard-1.20.1-2.7
curios-forge-5.11.0+1.20.1
CutThrough-v8.0.2-1.20.1-Forge
CyclopsCore-1.20.1-1.19.5
Delightful-1.20.1-3.6
design_decor-0.4.0b-1.20.1
deuf-1.20.1-1.3
dimasctetracompat-1.20.1-1.4.0.1
dimensionalsycnfixes-1.20.1-0.0.1
displaydelight-1.2.0
domum_ornamentum-1.20.1-1.0.284-snapshot-universal
dragonfight-1.20.1-4.6
drippyloadingscreen_forge_3.0.9_MC_1.20.1
DungeonsAriseSevenSeas-1.20.x-1.0.2-forge
dungeons_enhanced-1.20.1-5.2.2
EasyAnvils-v8.0.2-1.20.1-Forge
EasyMagic-v8.0.1-1.20.1-Forge
eeeabsmobs-1.20.1-0.95
effortlessbuilding-1.20.1-3.9-all
Eldritch_End-FORGE-MC1.20.1-0.3.2
elytraslot-forge-6.4.4+1.20.1
EnchantmentDescriptions-Forge-1.20.1-17.1.19
endersdelight-1.20.1-1.0.3
endrem_forge-5.3.3-R-1.20.1
enemyexpansion-2.3.1-forge-1.20.1
enigmaticaddons-1.1.3
EnigmaticLegacy-2.30.1
entity_model_features_forge_1.20.1-2.2.6
entity_texture_features_forge_1.20.1-6.2.7
EpheroLib-1.20.1-FORGE-1.2.0
EquipmentCompare-1.20.1-forge-1.3.7
EuphoriaPatcher-0.3.4-forge
extendedgears-2.1.1-1.20.1-0.5.1.f-forge
fabric-api-0.92.0+1.20.1
fabric-api-0.92.2+1.11.8+1.20.1
Fallingleaves-1.20.1-2.1.0
fancymenu_forge_3.3.2_MC_1.20.1
FarmersDelight-1.20.1-1.2.4
FarmersStructures-1.0.3-1.20
farsight-1.20.1-3.7
fast-ip-ping-v1.0.5-mc1.20.4-forge
fastasyncworldsave-1.20.1-2.0
fastpaintings-1.20-1.2.7
ferritecore-6.0.1-forge
ForgeConfigScreens-v8.0.2-1.20.1-Forge
framework-forge-1.20.1-0.7.11
friendsandfoes-forge-mc1.20.1-3.0.5
ftb-library-forge-2001.2.4
ftb-quests-forge-2001.4.9
ftb-teams-forge-2001.3.0
ftb-xmod-compat-forge-2.1.1
fullstackwatchdog-1.0.1+1.19.2-forge
geckolib-forge-1.20.1-4.4.9
GeckoLibOculusCompat-Forge-1.0.1
Geophilic v3.1.4 f15-57
GeophilicReforged-v1.2.0
GlitchCore-forge-1.20.1-0.0.1.1
goblins_tyranny-1.2.3-forge-1.20.1
goblintraders-forge-1.20.1-1.9.3
gpumemleakfix-1.20.1-1.8
HammerLib-1.20.1-20.1.33
handcrafted-forge-1.20.1-3.0.6
Hearths v1.0.1 f12-48
Highlighter-1.20.1-forge-1.1.9
Iceberg-1.20.1-forge-1.1.25
idas_forge-1.10.1+1.20.1
IllagerInvasion-v8.0.6-1.20.1-Forge
ImmediatelyFast-Forge-1.3.1+1.20.4
immersive_aircraft-1.1.2+1.20.1-forge
ImprovableSkills-1.20.1-20.1.11
IntegratedDynamics-1.20.1-1.25.0
IntegratedScripting-1.20.1-1.0.9
IntegratedTerminals-1.20.1-1.6.3
IntegratedTunnels-1.20.1-1.8.33
integrated_api-1.5.1+1.20.1-forge
integrated_stronghold-1.1.1+1.20.1-forge
integrated_villages-1.0.1+1.20.1-forge
interiors-0.5.6+forge-mc1.20.1-build.104
item-filters-forge-2001.1.0-build.59
Item-Obliterator-NeoForge-MC1.20.1-2.3.1
Jade-1.20.1-forge-11.11.1
JadeAddons-1.20.1-Forge-5.3.1
jei-1.20.1-forge-15.20.0.105
justenoughbreeding-forge-1.20.x-1.4.1
JustEnoughProfessions-forge-1.20.1-3.0.1
JustEnoughResources-1.20.1-1.4.0.247
justhammers-forge-2.0.3+mc1.20.1
Kambrik-6.1.1+1.20.1-forge
Kiwi-1.20.1-Forge-11.8.20
konkrete_forge_1.8.0_MC_1.20-1.20.1
kotlinforforge-4.11.0-all
KryptonReforged-0.2.3
LeavesBeGone-v8.0.0-1.20.1-Forge
letsdo-vinery-forge-1.4.38
libertyvillagers-2.0.0+forge+1.20.1
lionfishapi-1.9
lithostitched-forge-1.20.1-1.3.4
lmft-1.0.4+1.20.1-forge
Log-Begone-Forge-1.20.1-1.0.8
lootintegrations-1.20.1-3.7
lootintegrations_yungs-1.2
lost_aether_content-1.20.1-1.2.3
Luna-FORGE-MC1.19.X-1.0.1
L_Enders_Cataclysm-2.16 - 1.20.1
melody_forge_1.0.3_MC_1.20.1-1.20.4
memorysettings-1.20.1-5.5
mes-1.3.4-1.20-forge
minecolonies-1.20.1-1.1.603-RELEASE
mineraldelight-1.4
miners_delight-1.20.1-1.2.3
missions-forge-0.3.6
mns-1.0.3-1.20-forge
modernfix-forge-5.19.4+mc1.20.1
moonlight-1.20-2.13.21-forge
mopeds_1.1_1.20.1
morevillagers-forge-1.20.1-5.0.0
MouseTweaks-forge-mc1.20.1-2.25.1
mowziesmobs-1.6.5
multipiston-1.20-1.2.43-RELEASE
mutil-1.20.1-6.1.1
mvs-4.1.4-1.20-forge
MyNethersDelight-1.20.1-0.1.7.5
NaturesCompass-1.20.1-1.11.2-forge
Neat-1.20.1-37-FORGE
Necronomicon-Forge-1.6.0+1.20.1
Neruina-2.1.2-forge+1.20.1
NetherChested-v8.0.4-1.20.1-Forge
notenoughanimations-forge-1.7.6-mc1.20.1
obscure_api-15
oculus-flywheel-compat-forge1.20.1+1.1.3b
oculus-mc1.20.1-1.7.0
open-parties-and-claims-forge-1.20.1-0.23.2
OverflowingBars-v8.0.1-1.20.1-Forge
packetfixer-forge-1.4.2-1.19-to-1.20.1
Paintings-forge-1.20.1-11.0.0.2
Patchouli-1.20.1-84-FORGE
Paxi-1.20-Forge-4.0
peaceful_hunger-merged-1.20.1-1.0.0
pickableorbs-1.20.1-3.0.1
piglinsafety-1.18.2-1.0.0
player-animation-lib-forge-1.0.2-rc1+1.20
polymorph-forge-0.49.5+1.20.1
Prism-1.20.1-forge-1.0.5
protection_pixel-1.0.8-forge-1.20.1
PuzzlesLib-v8.1.24-1.20.1-Forge
Quark-4.0-460
quark_delight_1.0.0_forge_1.20.1
radium-mc1.20.1-0.12.4+git.26c9d8e
Raided-1.20.1-0.1.4
rebind_narrator-forge-1.20.1-2.0.2
recipeessentials-1.20.1-3.6
redirector-5.0.0
repurposed_structures-7.1.15+1.20.1-forge
resourcefulconfig-forge-1.20.1-2.1.2
resourcefullib-forge-1.20.1-2.1.29
ResourcePackOverrides-v8.0.3-1.20.1-Forge
rustic_engineer-1.20.1-1.0.7
sawmill-1.20-1.4.3
ScorchedGuns-0.3.6-1.20.1
Searchables-forge-1.20.1-1.0.3
seasonal_lets_do-forge-1.1.0
SereneSeasons-forge-1.20.1-9.1.0.0
sereneseasonsfix-1.20.2-1.1.0.1
ServerBrowser-1.20.1-FORGE-1.3.0
servercore-forge-1.5.1+1.20.1
servercountryflags-1.10.1-1.20.1-FORGE
ShieldExpansion-1.20.1-1.1.7a
SimpleDiscordRichPresence-forge-4.0.3-build.40+mc1.20.1
skinlayers3d-forge-1.7.0-mc1.20.1
sliceanddice-forge-3.3.0
smarterfarmers-1.20-2.1.0
smoothchunk-1.20.1-3.6
SnowRealMagic-1.20.1-Forge-10.5.2
sodiumdynamiclights-forge-1.0.9-1.20.1
sodiumoptionsapi-forge-1.0.5-1.20.1
sophisticatedbackpacks-1.20.1-3.20.11.1121
sophisticatedcore-1.20.1-0.6.35.733
sophisticatedstorage-1.20.1-0.10.45.921
soul-fire-d-forge-1.20.1-4.0.6
spark-1.10.53-forge
sparsestructuresreforged-1.20.1-0.0.1
spyglass_improvements-1.5+mc1.20+forge
Steam_Rails-1.6.7+forge-mc1.20.1
Stony Cliffs FML v1.1.2
storagedelight-24.12.15-1.20-forge
structureessentials-1.20.1-3.4
structure_gel-1.20.1-2.16.2
structurize-1.20.1-1.0.742-RELEASE
supermartijn642configlib-1.1.8-forge-mc1.20
supermartijn642corelib-1.1.17a-forge-mc1.20.1
supplementaries-1.20-3.0.6
tact-1.2.1+1.20.1
tacz-1.20.1-1.1.4-hotfix-all
takesapillage-1.0.3-1.20.1
tempad-forge-1.20.1-2.3.4
tempadwithshaders-1.20.1-1.0.0
TerraBlender-forge-1.20.1-3.0.1.7
tetra-1.20.1-6.4.0
tetracelium-1.20.1-1.3.0
tetraextras-0.1.4-1.20.1
tetranomicon-1.5.3-1.20.1
tfmg-0.9.3-1.20.1
the-conjurer-1.20.1-1.1.6
the-orcs-1.0-FORGE-1.20.x
ThinAir-v8.1.5-1.20.1-Forge
toms_storage-1.20-1.6.8
toms_trading_network-1.20-0.3.1
toofast-1.20-0.4.3.5
towntalk-1.20.1-1.1.0
transparent-forge-8.0.1+1.20.1
trashslot-forge-1.20-15.1.0
TravelersTitles-1.20-Forge-4.0.2
treeharvester-1.20.1-9.1
twilightforest-1.20.1-4.3.2508-universal
villagernames-1.20.1-8.1
visuality-forge-2.0.2
VisualWorkbench-v8.0.0-1.20.1-Forge
watut-forge-1.20.1-1.1.3
witheringboon-1.8.3
worldedit-mod-7.2.15
XaerosWorldMap_1.39.0_Forge_1.20
Xaeros_Minimap_24.5.0_Forge_1.20
xenon-0.3.31+mc1.20.1
YungsApi-1.20-Forge-4.0.6
YungsBetterDesertTemples-1.20-Forge-3.0.3
YungsBetterDungeons-1.20-Forge-4.0.4
YungsBetterEndIsland-1.20-Forge-2.0.6
YungsBetterJungleTemples-1.20-Forge-2.0.5
YungsBetterMineshafts-1.20-Forge-4.0.4
YungsBetterNetherFortresses-1.20-Forge-2.0.6
YungsBetterOceanMonuments-1.20-Forge-3.0.4
YungsBetterWitchHuts-1.20-Forge-3.0.3
YungsBridges-1.20-Forge-4.0.3
YungsCaveBiomes-1.20.1-Forge-2.0.1
YungsExtras-1.20-Forge-4.0.3
YungsMenuTweaks-1.20.1-Forge-1.0.2
Zeta-1.0-24
Oh hey, I've been trying the same modpack combo - and I think I get what's going on. The Steampunk modpack by default includes the Faithless resource pack, which includes custom models for many of the blocks, most notably bricks, in order to make their texture more consistent across the block's faces. (tl;dr: turn off the "Faithless" resource pack for a quick fix)
Now, take this all with a grain of salt, since I am by no means an expert, and only have a sort of passing knowledge of things in addition to trying to look into this myself.
In short, this is the issue - the soandso_bricks_model.png
files are being used as the "default texture" when applied to DO's blocks, which is a problem since these textures are unwrapped versions of the custom models used for the resource pack (hence the "repeating", improperly scaled texture), and they include transparencies in the unused space of the texture. It seems that the "holes" are simply the difference between how Minecraft's rendering and the shader's rendering treats these transparencies in the texture.
Now, why is this texture being used instead of the base/regular soandso_brick.png
files? From a quick glance into the code, this is my theory - Dormum Ornamentum it seems, when grabbing the base texture/model for the purpose of the block re-texturing, tries to get the "default blockstate". However, it may be going off of the current resource-pack defined blockstates, which may point towards these modified or incompatible textures/models as the "default", and not the vanilla minecraft blockstates, which should always point to a model that is compatible.
To fix this, theoretically (since I'm having a hard time finding where and how exactly the mod pulls its blockstates/textures in the code), when finding the textures for the re-texturing, it would use only the vanilla minecraft blockstates & models, but still try and grab whatever the current resource-pack defined version of the necessary texture is. This may fix many more issues when dealing with resource packs that modify models (for example, PureBDCraft, which results in invisible DO blocks in some cases, or the way this resource pack (Faithless) modifies the fence gate template models to make them consistent in the inventory, which in turn causes all modded fence gates using this model to display incorrectly when placed in the world).
Now, I don't know for sure if any of this is the case, but hopefully it helps give the developers some idea of where to start if they want to look into this. I'll continue looking through the code to see if there's any obvious places where this can be fixed, but since I don't really have any experience here, it's mostly up to them.
My apologies if this is complete nonsense.