Double Slabs

Double Slabs

5M Downloads

Crafting override

A-T-L-A-S opened this issue · 4 comments

commented

Double slabs seem to override any crafting recipe that includes just one slab. Meaning if there is exactly one slab in the crafting the result will always be its's vertical variant; no matter which other items are present.

grafik

Minecraft version: 1.15.2 forge-31.2.36
Mod version: DoubleSlabs-1.15-2.11.5

I have quark installed and suspect that it might be a part of this problem but I have no clue tbh.

EDIT:
The issue seems to be a thing with create. I notice that this bug only appears when an item from create is present as well.
I will see if I can get some more info on that.

commented

According to the code, this would be because the recipe doesn't abort when checking the crafting inventory for valid slabs. I don't know why this would only trigger with Create items for you - it would seem as if this would happen in any arrangement where there is any number of crafting inputs but only one valid slab stack.

The relevant code, from what I can tell, is here:

public boolean matches(CraftingInventory inv, World world) {

commented

Hi, thanks for the issue and the responses. It seems that @gamrguy is correct in that the recipe does not check for any invalid items apart from multiple stacks which is an oversight on my behalf, sorry about that. I will get that patched and updated as soon as possible. Sorry for the inconvenience.

commented

Fixed in the latest version. Thanks for your patience

commented

Fixed in the latest version. Thanks for your patience

WOW - That was fast! 🤩 Thank you so much