Double Slabs

Double Slabs

5M Downloads

Incompatible Slabs

Unicoranium opened this issue ยท 20 comments

commented

Some modded slabs don't appear to work as expected.
Trying to place these slabs on top of a vanilla stone slab will instead place them in the block above as it would in vanilla.

image

The slabs that aren't connected are from actually additions (left) and jaopca (right)

Looking at their source code, it appears they are implementing their slabs as normal blocks with custom logic instead of extending vanilla slabs. This may be the cause.

Possible solutions could be checking if the custom logic of a block matches that of a slab and treating it as such, or getting those mods to change their classes to actually implement slabs

JAOPCA slab class (Not working)
Applied Energistics slab class (Working)

Edit: Changed image to have brighter slabs from the same mods for easier identification

commented

From what I can see this issue has been fairly quiet, unless there are any other compatibility issues, I'm closing this now.

commented

Yes, this is correct. They have implemented the slabs in a slightly different way than vanilla slabs but it would be possible I believe for me to make this work through making a change to the code I'm using. For which Minecraft version btw?

commented

Currently running MC 1.12.2 with DoubleSlabs-1.12-0.1.4.jar

There's also another bug with these slabs, which will probably be fixed with this already, but I'll state it anyways just in case. If I place one of these slabs and use it to place a double slab above it, it creates a vanilla double slab

image

All blocks place from bottom to top, left is vanilla double slab, right is doubleslabs double slab

commented

Thanks for this. I'll take a look and fix these as soon as possible

commented

Hi, I will add some more mods that have slabs not working well still:
Plants, Engineer's Decor.
@CJMinecraft01 I noticed that when using Double Slabs, chunk update tick (seen as teal line in optifine's lagmeter) doubles/triples for me when making those slabs creating a noticeable short freeze. Is it possible to somehow optimize it?

commented

Hi, thanks for the other mods which have slabs which don't work. Through looking at how those mods implement slabs, it is apparent that they implement their slabs in a means which cannot be detected by my mod. One way that this can be rectified is if the mod authors were to attach some extra code which adds integration directly with my mod. Regarding lag please use the #18 issue to post reports there. Would you be able to provide a list of mods (or which modpack) you are using the mod with. I have just done testing with SkyFactory 4 (which is fairly intensive on my PC) and have found no issues; however I have experienced some block placement lag before on an older version and would like to test this for a newer version myself. Thanks for the report!

commented

@CJMinecraft01 Yeah, it was Dynamic Surroundings. I posted mod list in that thread, so far only problems I noticed were those two mods I mentioned and DS. Do you plan any fix for DS compatability? Maybe also add whitelist to the config file where we could add custom slabs that does not work?

commented

Okay so the first issue should now be fixed regarding JAOPCA slabs, they should now work with the mod as well as a bunch more other mods. Let me know if the other issue is still present. Thanks :)

commented

It is available in the latest update (forgot to mention that)

commented

Yeah I do plan to fix compatibility with DS, have been trying to figure out how. The issue with adding a whitelist is that I need to know which half of the block is already present and be able to set which half to use which is easy for vanilla like slabs as I have access to the block state property but with other mods I don't which is where the issue is. I will try my best though!

commented

I can confirm some slabs that were originally not working are now working. However some still do not work as they would be expected to.

Modded slab on top
image
Modded slab on bottom
image

Source mod from left to right:
JAOPCAx3, Atum 2, Blockcraftery, NetherEx.

NetherEx and Atum 2 slabs appear to behave as though DoubleSlabs doesn't detect they are slabs.

There are two issues with the Blockcraftery slab. The first being its main functionality of mimicking other blocks is tied to its NBT which is not carried over even when you place the Blockcraftery slab first. It's special right click function I suspect would be harder to carry over to double slabs than just maintaining the existing nbt of the slab. Their second issue is they are partially transparent and cause the other half of their slab to be invisible.

JAOPCA slabs have an interesting situation. They appear to work fine as a bottom half, but as the top half they render on the bottom. Even as a double slab, the hit box is a full block but the bottom half

image

The bottom three are the bottom half of their column, the right three are the top half of their row. They all still form a full block hitbox but only render on the bottom half and the colors seem to merge.

commented

Yes when testing with JAOPCA slabs I noticed that the top half of the slab renders as the bottom but with the hitbox of the top. Is this the same for you?

commented

Yes, it does the same, which I thought was weird since The One Probe (and f3) says its still a JAOPCA block, but at the same time JAOPCA hasn't updated their slabs in a long time so nothing on their end should've changed

commented

Do the slabs work fine without my mod?

commented

I think they might have a model issue

commented

Just loaded a pack with just the JAOPCA mods and it has the same top half issue, but only for single slabs, double slabs appear as full blocks as expected

commented

Regarding the other mods that you were having compatibility issues, apparently Twilight Forest and Erebus slabs don't work. The only way I can see to fix this is for the mod authors of the other mods to add direct compatibility with my mod which shouldn't be too hard hopefully. I'm going to have a go at adding this to their mod and doing a PR

commented

The compatibility with Erebus, NetherEx and Atum 2 has been added in the latest version. I do plan to work on adding better support for Blockcraftery at a later date but I will have to alter how the slab creation and rendering works

commented

@CJMinecraft01 there should be a PR now that could work for compatability with Engineer's Decor but might need some more testing. I have not forwarded the topic to the dev of Plants as I have found out he is not developing the mod anymore.

commented

Fantastic, I'll add it as soon as possible!