[Bug/Suggestion] Conflicting enchantments can be active at the same time
Saklad5 opened this issue · 4 comments
Base information
- Minecraft version: 1.12.2
- Mod version: 1.12-2.3.8.279
- Minecraft Forge version: 14.23.1.2587
- Mod Pack: Direwolf20 1.12 v1.7.1
While having the ability to turn enchantments on and off is extremely cool, it is currently possible to abuse this to stack mutually-exclusive enchantments. As an example:
- Add Sharpness V
- Turn off Sharpness V
- Add Smite V
- Turn on Sharpness V
Doing this will cause both enchantments to be active, which is definitely not the intended design. That being said, being able to switch enchantments is a neat feature, so I think having conflicting enchantments should be allowed.
I suggest preventing conflicting enchantments from being on at the same time as each other, in much the same way that you cannot have Explosion and Arrow of Draconic Fire on at the same time. If someone wants to use Smite V, they should have to first turn off Sharpness V.
I’d appreciate it if you made an exception for Silk Touch and Looting, though: it makes no sense that those conflict, and I actually discovered this exploit when trying to get both onto my Draconic Staff of Power. If this bug didn’t exist, I would have used commands to get them together.
On a related note, it’d be cool to have the same enchantment toggles for armor as well. Switching from Protection to Blast Protection as needed would be great.
Nice point. You know however, that you can edit the first page? That means you could have put the second thing in the first one. Just saying. Also, I like this idea! Can't wait till he see's this!
I did that intentionally, since it’s separate from the bug/suggestion. It probably would be more appropriate to make a separate issue for it, but that just seemed unnecessary.