Draconic Evolution

Draconic Evolution

Mods
77M Downloads

CustomFusionRecepies not working properly.

Glebenator opened this issue ยท 9 comments

commented

Base information

  • Minecraft version: 1.12
  • Mod version: 2.3.10
  • Minecraft Forge version: 14.23.2.620
  • Mod Pack: custom

Crash report

[22:26:51] [main/ERROR] [draconicevolution/]: Something when wrong while attempting to load recipes from CustomFusionRecipes.json
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: java.lang.IllegalStateException: This is not a JSON Array.
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at com.google.gson.JsonElement.getAsJsonArray(JsonElement.java:106)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at com.brandon3055.draconicevolution.lib.RecipeManager.loadRecipesFromConfig(RecipeManager.java:144)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at com.brandon3055.draconicevolution.lib.RecipeManager.loadRecipes(RecipeManager.java:116)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at com.brandon3055.draconicevolution.lib.RecipeManager.registerEvent(RecipeManager.java:57)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_827_RecipeManager_registerEvent_Register.invoke(.dynamic)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:143)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:746)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.common.crafting.CraftingHelper.loadRecipes(CraftingHelper.java:622)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.common.Loader.initializeMods(Loader.java:718)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:352)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:534)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:377)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraft.client.main.Main.main(SourceFile:123)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at java.lang.reflect.Method.invoke(Method.java:498)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
[22:26:51] [main/INFO] [STDERR/]: [com.brandon3055.draconicevolution.lib.RecipeManager:loadRecipes:120]: 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Basically, I just copied the appropriate name from the .txt file. (and changed the extension of course)

commented

Ok, removing all the comments seem to fix the issue.
something to look for.

commented 
[
    {
        "mode": "ADD",
        "result": "minecraft:beacon",
        "catalyst": "minecraft:nether_star",
        "energy": 1000,
        "tier": 1,
        "ingredients": [
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:obsidian"
        ]
    },
    {
        "mode": "ADD",
        "result": "minecraft:diamond_sword,1,0,{ench:[0:{lvl:5s,id:21s},1:{lvl:5s,id:20s},2:{lvl:5s,id:19s}]}",
        "catalyst": "minecraft:golden_apple,1,1",
        "energy": 1000,
        "tier": 1,
        "ingredients": [
            "ore:oreGold",
            "ore:blockGold",
            "ore:ingotGold",
            "minecraft:stone,1,0,{ench:[0:{lvl:5s,id:21s},1:{lvl:5s,id:20s},2:{lvl:5s,id:19s}]}"
        ]
    },
    {
        "mode": "REMOVE",
        "result": "draconicevolution:draconic_staff_of_power",
        "catalyst": "draconicevolution:draconic_pick",
        "ingredients": [
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_shovel",
            "draconicevolution:draconic_sword",
            "draconicevolution:awakened_core"
        ]
    },
    {
        "mode": "REMOVE",
        "result": "draconicevolution:draconic_shovel",
        "catalyst": "draconicevolution:wyvern_shovel"
    }    
]

Here. Its a working one.
Though i have just tried to craft the sword, and it seems like a regular sword without any enchantments or anything.

commented

Please provide the json you used.

commented

Can you provide the json that this issue happens with, kina pointless having the working one ;)

commented

well its just a default .txt file.

commented

Yeah, closing this as user error, its an infomation document with an example.

commented

Wait, you just renamed the .txt file to .json? Because that wont work, it tells you how to use the system and provides an example..

commented 
//The recipe format has recently been updated! Old recipes will still work but may be disabled in a future MC version.

It is now possible to add custom fusion recipes and/or remove existing ones.
This feature is intended for Mod pack creators.

Recipes are specified using json file which you will need to place in config/brandon3055 (The same folder you should have found this text document in)
The json MUST be named "CustomFusionRecipes.json" (Without the quotes)

The following is an example of what the json file should look like (See further down for an explanation of what everything means)

[
    {
        "mode": "ADD",
        "result": "minecraft:beacon",
        "catalyst": "minecraft:nether_star",
        "energy": 1000,
        "tier": 1,
        "ingredients": [
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:glass",
            "minecraft:obsidian"
        ]
    },
    {
        "mode": "ADD",
        "result": "minecraft:diamond_sword,1,0,{ench:[0:{lvl:5s,id:21s},1:{lvl:5s,id:20s},2:{lvl:5s,id:19s}]}",
        "catalyst": "minecraft:golden_apple,1,1",
        "energy": 1000,
        "tier": 1,
        "ingredients": [
            "ore:oreGold",
            "ore:blockGold",
            "ore:ingotGold",
            "minecraft:stone,1,0,{ench:[0:{lvl:5s,id:21s},1:{lvl:5s,id:20s},2:{lvl:5s,id:19s}]}"
        ]
    },
    {
        "mode": "REMOVE",
        "result": "draconicevolution:draconic_staff_of_power",
        "catalyst": "draconicevolution:draconic_pick",
        "ingredients": [
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_ingot",
            "draconicevolution:draconic_shovel",
            "draconicevolution:draconic_sword",
            "draconicevolution:awakened_core"
        ]
    },
    {
        "mode": "REMOVE",
        "result": "draconicevolution:draconic_shovel",
        "catalyst": "draconicevolution:wyvern_shovel"
    }    
]


The above json adds 2 recipes for vanilla items and removes 2 recipes from Draconic Evolution. It should be fairly clear how those examples work
The following explains the recipes in more detail

# Adding Recipes #

"mode":
- For adding recipes mode can be set to "ADD" or it can be left out and the recipe will default to the ADD function

"result":
- This is the item stack that the recipe will create.
- This should be a specific item. It can not be an ore dictionary item.

"catalyst":
- The catalyst is the item that gets combined with the ingredients to create the result. 
- This should be a specific item. It can not be an ore dictionary item.

"energy":
- This id the energy required for the crafting. Note that this number is multiplied by the number of ingredients.
Meaning if you specifies 1000 for a recipe that has 8 ingredients the total energy cost would be 8000RF.

"tier":
- This is the crafting tier of this recipe 0 = basic, 1 = wyvern, 2 = awakened, 3 = chaotic

"ingredients":
- This is a list of ingredients required for the recipe.
- These can be ore dictionary items.


# Removing Recipes #

"mode":
- Mode must be set to "REMOVE" when removing a recipe

When removing recipes you to not need to specify the tier or energy cost of the target recipe.
You can instead just specify the result, catalyst and ingredients of the target recipe.
Optionally if you leave out the ingredients it will remove any recipe matching the result and catalyst items.


## Item Stack Strings ##

Example:      minecraft:wool,16,14     - This is 16 red wool
Ore Example:  ore:ingotCopper          - This is 1 copper ingots using the ore dictionary
Note: Ore entries do not support more that 1 stack size, Item damage or nbt
More on the ore dictionary http://www.minecraftuniversity.com/forge/ore_dictionary_list/

The name used in the item/block registry name or an ore dictionary name. Both the number of items and the damage value are optional

Examples:
name, stack size, meta, NBT
ore:stone
minecraft:stone         
minecraft:stone,64       
minecraft:stone,64,3 
minecraft:stone,64,3,{NBT}


### Notes ###
The order in which you add/remove recipes dose not matter when replacing recipes. 
Meaning for example you can add a recipe for a DE item then remove the original recipe and it will not remove the one you jsut added.

You can use ore dictionary items for the catalyst and result when adding recipes but the default fusion implementation dose not support that. 
So they will be replaced with the first item stack from the ore dictionary that matches that name.
commented

here