Draconic Evolution

Draconic Evolution

Mods
77M Downloads

Dislocator Receptable does not recognize an Advanced Dislocator as a valid dislocator

depressed-pho opened this issue ยท 2 comments

commented

Base information

  • Minecraft version: 1.12.2
  • Mod version: 2.3.13.306

Description

Advanced Dislocator can be stored in Dislocator Receptable but it doesn't actually activate the portal.

Steps to reproduce

  1. Register a location to an Advanced Dislocator and select it.
  2. Right-click a receptable while holding the dislocator.
  3. The dislocator gets stored in the receptable, but the portal doesn't activate.

Possible cause

Dislocator.java:173:

    public TeleportLocation getLocation(ItemStack stack, World world) {

DislocatorAdvanced.java:149:

    public Teleporter.TeleportLocation getLocation(ItemStack stack) {

The latter doesn't actually override the former so the wrong implementation of getLocation is used by the receptable. Haven't tested the Pedestrial yet but it's likely to be affected as well.

commented

This also seems to affect the receptor cloning recipe.

Steps to reproduce

  1. Place a configured Advanced Dislocator onto the first slot of a crafting table.
  2. Place an empty Dislocator onto the second slot of a crafting table.
  3. No crafting results are shown.

RecipeDislocatorClone.java:56:

            TeleportLocation location = ((Dislocator) source.getItem()).getLocation(source, null);
            if (location == null) {
                return ItemStack.EMPTY;
            }
commented

This will be fixed in the next release.