Draconic Evolution

Draconic Evolution

Mods
77M Downloads

AT causes setupDecompWorkspace to fail when DE is added as a dependency

BrainStone opened this issue ยท 0 comments

commented

Base information

  • Minecraft version: 1.12.2
  • Mod version: 1.12.2-2.3.17.321
  • Minecraft Forge version: 14.23.5.276814.23.5.2768

I'm trying to use this mod as a dependency and when I try to setup my workspace I get this rather lovely error while trying to run ./gradlew setupDecompWorkspace.

The offending line is this: https://github.com/brandon3055/Draconic-Evolution/blob/929a0e213e119932ac5d42fc51ef5e9eca1fb93b/src/main/resources/DraconicEvolution_at.cfg#L12

It could be fixed by adding the respective entries for the other classes, as inheritance isn't done automatically.
Though protected methods really shouldn't be made public. It's waiting to blow up.

Crash report (during ./gradlew setupDecompWorkspace)

> Task :recompileMc
[ant:javac] Compiling 2880 source files to C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\compiled
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraft\item\ItemAppleGold.java:42: error: onFoodEaten(ItemStack,World,EntityPlayer) in ItemAppleGold cannot override onFoodEaten(ItemStack,World,EntityPlayer) in ItemFood
[ant:javac]     protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player)
[ant:javac]                    ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] C:\Users\Yannick\Modding\BrainStoneMod\build\tmp\recompileMc\sources\net\minecraft\item\ItemFishFood.java:35: error: onFoodEaten(ItemStack,World,EntityPlayer) in ItemFishFood cannot override onFoodEaten(ItemStack,World,EntityPlayer) in ItemFood
[ant:javac]     protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player)
[ant:javac]                    ^
[ant:javac]   attempting to assign weaker access privileges; was public
[ant:javac] Note: Some input files use or override a deprecated API.
[ant:javac] Note: Recompile with -Xlint:deprecation for details.
[ant:javac] Note: Some input files use unchecked or unsafe operations.
[ant:javac] Note: Recompile with -Xlint:unchecked for details.
[ant:javac] 2 errors