Draconic Evolution

Draconic Evolution

77M Downloads

[1.16] Fusion Crafting Core putting out comparator signal even when no item inside after craft complete

e30Birdy opened this issue ยท 6 comments

commented

Base information

  • Minecraft version: 1.16.5
  • Mod version: Draconic-Evolution-1.16.5-3.0.17.420-universal
  • Minecraft Forge version: 1.16.5-forge-36.2.9
  • Mod Pack: FTB OceanBlock

Description / steps to reproduce

So i can a crafter from refined storage set to a chest and redstone signal that a pulse unlocks it so that it will input next recipe. Problem is that after fusion crafting core is complete with crafting it continues to send out signal to comparator unless one clicks don't the comparator twice by hand. I have this same setup running with Powah energizing orb crafting and it works flawlessly. When it is crafting the comparator lights up and when it is complete it send out the pulse and allows my crafter to put in next recipe.

commented

@e30Birdy Considering I just pushed the last batch of fixed/updates yesterday it may be a little while before this fix makes it to curse. In the meantime if you need the fix now you can get the latest build directly from maven. https://maven.covers1624.net/com/brandon3055/draconicevolution/Draconic-Evolution/1.16.5-3.0.18.429/Draconic-Evolution-1.16.5-3.0.18.429-universal.jar

Thanks so much that fixed the issue and auto crafting and pulling redstone signal from core works great. Can't wait to read the changelog to see what else is fixed/changed.

commented

The entire Fusion Crafting system is going to be rewritten. The current system is pretty much hacked together just to work good enough until it's finished.

Once that goes through, I'm sure this issue will simply disappear due to the rewrite.

commented

The entire Fusion Crafting system is going to be rewritten. The current system is pretty much hacked together just to work good enough until it's finished.

Once that goes through, I'm sure this issue will simply disappear due to the rewrite.

Oh cool, looking forward to the update, would love to finally see a controller or something making it a bit nicer to automate/power.

commented

@FoxMcloud5655 Most of the fusion rewrite has already been finished. 00dd64a
That was mainly complete were write of the core logic, rendering and GUI. But the new GUI is a bit boring and I'm not entirely happy with the rendering so I will probably revisit it at some point but for now it is 'done'

But with rewrites coms the potential for new bugs to creep in. In this case, it seems I am simply forgetting to trigger a block update when the crafting operation completes. This will be fixed in the next update.

commented

Oh, neat! I didn't know the actual progress of the rewrite, so I'm glad it's mostly finished then.

commented

@e30Birdy Considering I just pushed the last batch of fixed/updates yesterday it may be a little while before this fix makes it to curse. In the meantime if you need the fix now you can get the latest build directly from maven.
https://maven.covers1624.net/com/brandon3055/draconicevolution/Draconic-Evolution/1.16.5-3.0.18.429/Draconic-Evolution-1.16.5-3.0.18.429-universal.jar