Draconic Evolution

Draconic Evolution

Mods
79M Downloads

[1.20.1] NullPointerException when opening DisenchanterGui

AgentK20 opened this issue ยท 1 comments

commented

Base information

  • Minecraft version: 1.20.1
  • Mod version: 3.1.2.583
  • Minecraft Forge version: 47.3.5
  • Mod Pack: Heavily modified version of Worldly Galaxies 4.18

Crash report

https://pastebin.com/P4PWVHe9

Description / steps to reproduce

Repro steps on my pack: Put an iron sword (unsure what enchants were on it) in the Disenchanter. Game crashes.

Pretty sure this crash isn't explicitly DE's fault (more likely a bad mod interaction with something changing how enchantments work), but looking through the source I can see that the DisenchanterGui is unsafely handling a potential null within DisenchanterGui.populateList. getEnchantmentFromTag can return null, which is then immediately passed into getCostInLevels which blows up, unlike other handling with the same file.

I'm going to keep digging on my side to see which of the mods is causing a null Enchantment to be returned, but a potential fix on the DE side would be to validate the return of getEnchantmentFromTag as non-null before allowing an item to be placed in the Disenchanter.

Thanks!

commented

Is it the Beheading enchantment from Mana & Artifice?