Draconic Evolution

Draconic Evolution

77M Downloads

[1.10.2, 1.11.2] ModCompat: Torchmaster

Xalcon opened this issue · 1 comments

commented

Hi!
I'm the developer of torchmaster. I've got a bug report regarding my mega torch and the DE StabilizedSpawner: My torch blocks the spawn attempts from your StabilizedSpawner, which is not intended. Sadly, there is no way for me to detect if the spawn attempt is done via the WorldSpawner or some artificial mobspawner like your StabilizedSpawner, and I hope we can find a way to work around this issue. For vanilla, I simply patch all mobspawner tile entities to spawn entities with an additional Tag IsSpawnerMob in their Tag list. (Not needed in 1.12 thanks to MinecraftForge/MinecraftForge#4075)

I could do something similar with the stabilized spawner but i rather work out something with you so we dont work against each other or cause more issues in the future :)

The easiest way to resolve this would be adding an IsSpawnerMob NBTString to the Entities Tag list. This is a single line of code that can be added to the spawning code, something like this would be sufficient: entity.addTag("IsSpawnerMob");

I'm considering doing this myself by overriding your MobSoul class (replacing the instance in the DEFeatures class) and adding the tag in the createEntity() method. But since this is a change that could possibly lead to issues in the future, i'd like to get your consent on this. (It also helps for future issues to know who is messing with your classes :P)

This change will only need to be done to the 1.10.2 and 1.11.2 versions. 1.12 can handle it properly via CheckSpawn#isSpawner() :)

commented

Too easy! This change will be in the next update.