DragN's Livestock Overhaul!

DragN's Livestock Overhaul!

112k Downloads

Config - Turning off O-Animals doesnt work for Bees

Thats-MyLive opened this issue · 14 comments

commented

Bug Description:
In my small modpack I also have the Productive Bees Mod.
Which is why I wanted to turn off O-Bees from spawning and did so in the config, so that I only get Productive Bees Mod ones.

However despite setting it to false, the O-Bees still spawn and completely disabled any of the Productive Bees from spawning. I can manually use spawn eggs in creative mode to spawn them, but in the wild I only find O-Bees and empty Productive Bees Nests.

Mod Version: 1.4 (noticed this in 1.3 but tested it today in 1.4 too)

Minecraft Version: 1.20.1

Screenshot (Optional):

Have you tried removing other mods? Did the issue persist after removing them?: I have tested it with just O-Bees installed and the Config file just does not turn O-Bees off from spawning.
I also tested turning off O-Cows and O-Sheep to see if it may be the config file, but those turn off just fine.

Are you on Singleplayer or a Server?: Singleplayer

commented

I went and looked into this and mine are turning on/ off just fine. I can't seem to replicate this issue.

I'm on 1.20.1-1.5, dev environment (aka, no other mods installed)

Make sure you're restarting the game after changing your config. O-Bees don't convert back into vanilla bees after being changed, but vanilla bees can be turned into O-Bees after being changed.

After changing your config to not convert bees, you'll need to find newly-spawned ones and they'll be vanilla.

commented

I have always restarted my game and created a new world to test spawning,
to avoid any compatibilities on older worlds and test fresh spawning.

I'll do another try and refresh my forge version and redownload the mod/s to test again, maybe having older config files or idk what could have blocked it then. I'll report back when I tested again.

commented

Freshly cleaned out my MC Folder, installed a new 1.20.1 and forge.

I now only have:
forge-1.20.1 47.3.12
Livestock_Overhaul-1.20.1-1.5
geckolib-neoforge-1-20-1-4.4.9

I loaded up the game once without touching any config files (since there were none generated yet before that).
Started up a world and found bees, which were O-Bees, to check that the mod is working.

Closed the game, opened the config to turn O-Bees off. (I checked twice if I potentially missspelled it or put an extra spacebar in, but I am fairly sure its correct). Saved the config and then restarted the game.

RUsed "re-create" to make a new savegame of the same world/seed (so I knew where to find bees right away, but in a newly created world). The Bees still spawned in as O-Bees.

I have now no other mods installed and a completely fresh MC and Forge version.
Could it potentially be an issue with a specific geckolib or forge version?
I dont know what else I could update/change now to not get O-Bees spawning.

commented

You're using a Neoforge version of Geckolib instead of Forge. I don't think that's the issue here since the spawning has nothing to do with Gecko but try using just a Forge version and see if that changes anything (maybe something's not updating correctly with the render)

You could also try deleting all of your LO configs and reloading them by just loading up the game again. Maybe that would help?

Otherwise, I've really no idea. Like I actually can't replicate this; it's always been fine on my end, even on the earlier versions of LO

I tested it earlier and I could switch it on and off as I pleased. I just had to spawn some new vanilla bees in after turning the config to false and they would spawn in as vanilla bees

I can try again tomorrow... later..? And see if I can replicate it. Maybe I'm doing something wrong. I didn't really test it on naturally-spawned bees, thinking it didn't matter since the replacer code affects all bees, but maybe it really does matter. Will update you if I find anything weird

commented

Didnt pay attention that geckolib had separate forge/neoforge versions.
But I tested the forge version now, no change.

Also deleted the config files and let them freshly create to test again, no change.

I mean I can at least use O-Bees with Productive Beehives now, so I can work towards luring in the right bees manually, but this is really odd.

If you need a closer look I can also join the discord and connect with ya to troubleshoot, I really have no Idea at this point either anymore xD

commented

To be exact, the naturally spawning bees from hives are all always O-Bees. Using a spawn egg for vanilla bees works with the config O-Bees off, but not the normal world spawning ones.

commented

The only thing I can think of is that a vanilla bee is entering the hive, but our code is (accidentally) converting it into an O-Bee when it comes back out.

We have custom logic for beehives since they cause a pretty insane bug with the O-Bees if we didn't have it. I'll ask Gotenks, since he made the logic for the hives, and see if we can work it out and find any hiccups 🤔

commented

That could make sense why it then also has issue with letting the Solitary Bees from Productive Bees not spawn at all, if the hives convert Bees unintentionally, that would make Solitary ones not be able to spawn in either I guess.

I'm sorry this is making trouble.
The bees just seem to like me and dont want to leave.

commented

I have done some more testing, to see if Vanilla Bees can enter and exit hives and what happens with them.

My conclusions for now are:

  • upon creating a new savegame, bees do not "spawn", they instead get generated within the hive
  • the hives spawn in always with O-Bees, even if O-Bees are turned off (guess it turns of spawning them, but not generating them upon world/hive creation when a world is made)
  • If I spawn Vanilla Bees manually, they are able to enter the hive and exit the hive as normal Vanilla Bee, so they do not get converted in the hive.

Which also leads me to believe that Productive Bee "Solitary Nests" spawn in WITH an O-Bee generated inside of it. Found that by trying to put a "Bee Treat" into a Solitary Nest to lure a Productive Bee into it. This did not work as it said the hive is occupied. After removing and replacing the Nest, I was able to lure a Bee to spawn there.

Since only Solitary Bees are supposed to be able to enter/spawn in Solitary Nests, O-Bees trapped inside cannot exit or interact with the Solitary Nest, blocking it and making it impossible for Productive Bees to spawn in.

So it seems to be a Bee Hive generation thing rather than the Bees spawning, since they start out in a hive?

commented

Thank you, I'll take a look at that.

commented

First off: Love the work you are doing and how quick you are, also adding new Content (new horse breeds are amazing!) I enjoy playing with the overhauled animals so much! <3

I tested Version 1.5

  • The Config still does not turn Bees off, with Productive Bees and with just Livestock Overhaul as the only mod.

  • I can now manually "lure" new Productive Bees into Solitary Hives (with their treats), however they will still not spawn naturally in those, despite O-Bees being on false in the config.

  • I can use O-Bees in the Productive Bees Hives now tho, so I am less concerned. Cause I can longterm actually get the treats to lure in needed bees as a workaround for now.

commented

Okay so:

  • Bees turned on: Replaces also "lured in" Productive Bees (making it impossible to get any Productive Bee)
  • Bees turned off: Still replaces vanilla Bees and prevents Solitary Productive Bees from naturally spawning, BUT lets Productive Bees manually get "lured" into the Solitary Hives.
commented

Excitedly reporting back! 1.8 the fix indeed works! I dont know how much work that probably was, but man: Huge respect! And big thank you! <3 Productive Bees now spawn and the normal vanilla bees too. ^^

commented

Awesome! Glad to hear