DML's datapack should be a low order priority
ClaudiusMinimus opened this issue ยท 8 comments
Could you add a scaling variable to allow adults to grow bigger? I've added your mod to my pack, Create Conquest Arcane, and would love to have bigger dragons.
Minecraft: 1.18.2
Dragon Mounts: 1.18.2-1.1.4
Also, your discord invite is invalid https://discord.gg/h8zRw9H
I just found this "size_modifier": 2,
in dragon_breeds/example_breed.json. Hopefully I can modify the size of existing dragons in a datapack!
Using kubejs to modify the fire.json I added "size_modifier": 8
as an experiment and it did not change the dragon size. Did I do it wrong?
{
"habitats": [
{
"point_multiplier": 1.0,
"block_tag": "dragonmounts:fire_dragon_habitat_blocks",
"type": "nearby_blocks"
},
{
"point_multiplier": 3.0,
"fluid_tag": "minecraft:lava",
"type": "in_fluid"
}
],
"immunities": [
"onFire",
"inFire",
"lava",
"hotFloor"
],
"hatch_particles": {
"type": "minecraft:flame"
},
"model_properties": {
"middle_tail_scales": false
},
"name": "dragonmounts:fire",
"primary_color": 9511936,
"secondary_color": 16750617,
"size_modifier": 8
}
To make it simple, I used your recommended Forge "lowcode" Mod
and made a custom dragon as described in example_addon readme rather than a datapack. Unfortunately, not all of the properties seem to be working, including:
"size_modifier": 4
"attributes": {
"minecraft:generic.armor": 20.0
}
cmsbiggerdragons-1.18.2-0.0.3.jar.zip
Lastly, it would be very helpful if there was documentation for all of the properties for customizing dragons.
hmm... I can't see what the issue would be causing this. I'll look into it however to ensure everythings all set.
You seem to have everything correct on your end.
As for documentation, yeah I realize its lacking. I haven't been able to get the time to write docs up for it. I apologize for that and I hope its not too much of a barrier.
Also please note that the custom size modifer is actually unreleased as of 1.1.4.
If your using a compiled version of the mod early, it may be because of a race condition.
Further testing is required.
Unfortunately, one of my keystone mods switched full support to Fabric for 1.19.2+, so I ported the pack to Fabric I did not find a Fabric version of your mod, so I ended up switching to Mythic Mounts.
I seemed to have misinterpreted how datapack load ordering works and it doesn't seem feasibly possible to have a mod alter the load order of itself. Unfortunately this seems like it might be an area that modpack authors have to adjust manually with the datapack
command.
However, it is to my understanding the standard datapacks have priority over a mod's datapack, so this issue is quite rare and should more likely be seen as a non-issue, especially with the above solution.