Dragon Mounts: Legacy

Dragon Mounts: Legacy

20M Downloads

[CRASH] breeding the dragons crashes the game?

DomezTheDragon opened this issue ยท 5 comments

commented

There seems to be a Null pointer issue that completely crashes the game when i try to breed 2 dragons (i am on the latest version of the mod)
This is 1.18.2 btw
mod ver: 1.1.5

commented

Could you provide a log if you have one? I can take a look into it either way, but the error from a log would help point me in the right direction.

commented

crash-2023-09-13_11.58.35-server.txt
this is the crash file

the flying crash is gonna be harder to catch but i think it's related to sounds or movement as it takes a random amount of time to happen (never happens while riding the dragon)

commented

crash-2023-09-13_11.58.35-server.txt this is the crash file

the flying crash is gonna be harder to catch but i think it's related to sounds or movement as it takes a random amount of time to happen (never happens while riding the dragon)

It seems majrusz' library is doing something with it. I'll see if replication with and without Majrusz affects it

With Majrusz: Crash
Without Majrusz: No Crash

commented

The issue is with compatibility between Majrusz library and this mod.

commented

This isn't actually an issue on my end.

Majrusz responds to when any "baby" might spawn due to a breeding of any animal. The problem with DML is that it doesn't spawn animals, it spawns an egg. (Whether it be a block in 1.19+ or a non-animal entity in 1.18)
Either way I cannot supply the proposed child in the MinecraftForge event. Luckily, the event also expects a nullable child. Aka a child not existing.

The problem with Majrusz is that it does NOT expect a nullable child. That is a check that needs to be performed on their end. I will make them aware of the issue and a possible proposed fix.