Dragon Mounts: Legacy

Dragon Mounts: Legacy

15M Downloads

[datapack/lowcode mod] Lang files are completely ignored in resource packs, but texture files load, regardless of how the addon is set up.

IceaPlayzPC opened this issue ยท 5 comments

commented

Back at it again at Krispy Kreme (making datapack and running into issues lol)

So with the new dragon mounts update, i wanted to update my multiplayer world to the new version since i put my still WIP data pack in there (not a good move on my end since i wasn't expecting it to break completely next mod update lol), but i practically have to rewrite my datapack from the ground up due to changes to how the json entries are written. Yeah, easy enough, that ain't an issue at all just a bit extra work.

However, i ran into a huge problem in that the resource pack is not being read properly. I've tried practically everything under the sun (to my knowledge). The textures load fine without issue, in fact when i ported one of my breeds it found its corresponding texture file without any issues. However the language file and the new model property files are entirely ignored, which means the example breed gets its tail horns completely nuked despite having a file calling for that model property to be enabled.

Its not even a potential messy folder structure that's causing it because even the example addon with nothing added to it refuses to read the resource pack completely (meaning example breed does not have its tail horns). I even packaged everything into a lowcode mod with all pack formats put to 15 and still no reading of the language file and other files that aren't textures. I sent the example addon to someone who knows more about data packs than i do and he couldn't even get it to work. He noted that there was nothing in the logs stating what was wrong which is EXTRA puzzling.

Log: https://pastebin.com/m6Gfz8HW - this is my log from loading a lowcode mod with very few other mods (just xaeros minimap and world map installed). My friend tried loading it as a data + resource pack with no other mods and he has given me permission to share his log file so i can provide his upon request if needed, but our logs were fairly similar so i am just providing mine for now.

TL;DR, trying to update a datapack to the latest version, resource pack refuses to have anything but textures read properly regardless if its packaged as a datapack + resource pack or if its packaged as a lowcode mod, and even the example addon without any modifications has these issues.

Thanks in advance for any responses! I fully expect this issue to be just a New Update Moment(tm) so its not a huge deal since i can hold off on the update until things are going smooth again (or the alternative idea is that i'm a bit dumb and set something up wrong, but doubtful since the unedited example addon didn't work entirely. Its not game/mod development if something doesn't break once in a bit lol). Cheers ^^

commented

Maybe I missed something prior to testing; I'll have a look at it soon. There were some other issues in 1.2.0 that I also already addressed, and if I can verify your issues here, it'd warrant a patch release since this is kinda major for datapacks to actually function.

What's got me puzzled the most is why your language entries aren't loading correctly, as those are something vanilla handles, and I'd trust vanilla's data managers over my own, I wouldn't put it past mine breaking, lol.

I'll investigate soon, thank you for reporting.

commented

It looks like we came up with the solution at around the same time.. haha. So huge goof on my part for not keeping the example updated correctly.

I also managed to figure out the issue with the lang files. I should note, they ARE IN FACT loading correctly, and your breeds (if the syntax is correct, obviously) are given names. However the items (spawn egg, dragon egg) do not. One of the first things I did in 1.2 was separate how the egg and spawn eggs get their translation line. I structured language entries to be dynamically created in the mod for both the eggs and spawn eggs; basically originally they were made automatically. However, I received complaints from translators that the solution wasn't very custom or friendly to other languages, so I decided to make them all have separate entries in the lang files, thus the example wasn't updated correctly during that transition, and here we are.

To fix this, all you have to do is add those in the language entries, and will not require updating the mod. I apologize for the confusion here, I realize it's frustrating when that kind of stuff isn't documented correctly. I'm currently in the design process of having the example addon be generated by code, just like the base mod is, so my primitive human brain doesn't continue to leave these errors.

Nonetheless, I have pushed updates to the example which you can reference here to get things fixed up.

Happy flying!

commented

Haha funny how that worked out! That's great to hear that you figured out the language file problem ^^ Thanks so much!

Cheers!

commented

i come bearing an update.

I decided to work on my data pack as-is for the time being, and while moving the model properties area, i saw the json for the example breed and thought "hmm. the example breed property file is only called example and not example_breed. what if i..." and i changed it to example_breed and voila!
gitupdate

So the model properties area MIGHT not be as broken as initially thought, but i still have yet to get it to work with a custom breed (makes me wonder if i accidentally made a typo on my dragon breed when i originally tested a custom breed, or forgot to reload the resource pack. I wholly expect it to be that lmao).

The lang file being rogue is still an issue, however, which that was present in the base example pack so thats still unresolved. I'll update here again if i can get the model properties working for my custom breeds

commented

Back just over 20 minutes later, just finished porting my wither dragon breed and i gave him thin legs, and reloaded the resource pack and woo!
gitupdate2
I think my blunder with the models was i forgot to reload the resource pack and then the json file was named incorrectly for the base example dragon, so model properties actually work, i'm just a bit forgetful!

Going to rename the issue accordingly since model properties are not in fact broken, but language files still don't work ^^