Dragon Mounts: Legacy

Dragon Mounts: Legacy

15M Downloads

Light level test reversed for Ghost Dragon

mactso opened this issue ยท 4 comments

commented

The Light Level test for ghost dragons appears reversed.

Right now, they convert if they are underground, can't see the sky, and the light level is over 4.

Cheers.

commented

Wait how did you do the test? You went underground and had a light level of 4?

commented

We looked at the code, saw what it required, then set up the test conditions and validated them.

My test was a dark underground room with an aether dragon egg. it did not convert for 60 seconds. Then, I broke the wall blocking torchlight and the egg instantly converted to a ghost egg.

Other members of Two Guys did similar tests and confirmed the results.

We are using the mod in the Two Guys modpack and writing quests so we needed to give hints to people in the quests.

It looks like the programmer unintentionally reversed the light level condition when converting to Ternery operators. Personally, I just don't grok ternery operators. Heck- I frequently break compound if statements on to multiple lines. lol. it helps when I've been coding 18 hours.

Cheers!

commented

yup, that's indeed the case. My mistake! Thank you for pointing that out.

commented

no problem! Going to write the quests and hints for it as it is. I'll look for it if you decide to change it later.