Dragon Survival [Forge]

Dragon Survival [Forge]

685k Downloads

[1.18.2 Forge Bug]: MixinGameRenderer creates issues with night vision when using Iris ports and shaders

wchen1990 opened this issue · 0 comments

commented

■ Your Discord ID

BobDole#8232

■ Dragon Survival version

DragonSurvival_DragonEditor-1.18.2-0.11.4_beta.jar

■ Single game or server?

Single (Default)

■ Do you delete old configs before writing a bug report?

Nope (Default)

■ Do you play pure MC + DS and Geckolib or do you have some kind of modpack?

I have other mods

■ Describe the bug

When using Iris ports like Asek3's Oculus shaders receive the wrong nightVision value due to MixinGameRenderer's hard coded return of 1F. This makes it so that all shaders think that night vision is active while using Iris ports, regardless of if you're a dragon or not.

I'm not exactly sure what the purpose of MixinGameRenderer is, and disabling that particular mixin did not change anything as far as I can tell with dragons. If MixinGameRenderer is required for some use case, it'd be best to make sure it only returns 1F under specific circumstances rather than it's current implementation.

■ To Reproduce

  1. Use a Forge Sodium port and a Forge Iris port, like Rubidium and Oculus
  2. Use a shader pack that utilizes night vision values, like Complementary
  3. Go to a dark area or change the time to night

■ Expected behavior

Shaders should act as though they don't have night vision if the player doesn't have a night vision like ability.

■ Crash Report

N/A