■ Your Discord ID or other contacts

Peresha

■ Dragon Survival version and Modpack version (if have)

DragonSurvival-1.18.2-1.5.47.jar , DragonSurvival-1.18.2-1.5.48.jar
Play as Dragon Gothic Edition-10.08.2023

■ Single game or server?

Single (Default)

■ Do you delete old configs before writing a bug report?

I always delete configs

■ Bug Description and Reproduce

Играя за морского дракона, я использовал заклинание "шаровая молния" на моба Острозуба (upgrade_aquatic:thrasher), затем произошёл краш игры.
Это происходит в каждом новом мире.
Playing as a sea dragon, I used the spell "ball lightning" on the "upgrade_aquatic:thrasher", then the game crashed.
This happens in every new world.

■ Expected behavior

Майнкрафт не крашется.
Minecraft does not crash.

■ Crash Report File and Logs

crash-2023-08-27_01.52.12-server.txt

The trasher is adding itself as its own passenger
(And in the Server tick method the passengers of an entity also get ticked, resulting in the stack overflow)

Seems to stem from the Trasher having itself as a target
I'm assuming due to it setting its target based on who attacked it (and the charge effect has the spreader as the damage source, meaning it kind of damages itself)

You could create an issue here https://github.com/team-abnormals/upgrade-aquatic/issues
And ask them to add check so the Trasher doesn't add itself as a target or passenger

(Meanwhile you can also blacklist the trasher entities from the effect to avoid the crash, see chargedBlacklist and chargedSpreadBlacklist)

What to do if upgrade_aquatic:thrasher already in the chargedBlacklist and chargedSpreadBlacklist options?

server config (world save directory)
once you have edited the config you can place it in the defaultconfig directory (same level as mods directory) so your modified config gets applied to new worlds automatically

As I recall this config is broken and thrashers do cause crashes

Seems like the config doesn't seem to apply to all occurences of the charged effect at the moment

There is no check here
Added it in cce033e

This is the part where the trasher gets damaged by itself btw

DragonSurvival/src/main/java/by/dragonsurvivalteam/dragonsurvival/magic/abilities/SeaDragon/active/StormBreathAbility.java

Line 229 in 4b4d225

target.hurt(DamageSource.mobAttack(source), damage);

This is the part where the trasher gets damaged by itself btw

Charge effect applied through the storm breath itself might actually be safe, since the player reference is usually there in that case (meaning the damage source will be the player) (At least from the tests I did)