Dragon Survival [Forge]

Dragon Survival [Forge]

685k Downloads

[1.19.2 Bug]: Mending Exploit

LeviticusTheFluff opened this issue · 2 comments

commented

■ Your Discord ID or other contacts

LeviticusTheFluff

■ Dragon Survival version

Dragon Survival 26.01.2024

■ Forge/Neoforge version

Forge 43.3.7

■ Single game or server?

Host site

■ Describe the bug

When using a Mending 1 Book to repair armor that would otherwise be way too expensive to repair (247 levels for a chestpiece for example) The enchant cost is set as 5 which is expected and properly notated behavior in the modpack. What ISN'T expected, is that each subsequent repair or adding additional enchantments is ALSO reset. This can even be combined with books at an enchanting table that happen to roll Mending 1 along with a long list of other enchantments, to cost only 5 levels to enchant an otherwise ludicrous amount of enchantments onto an item.

Steps to reproduce
Get an expensive, well worn, high level enchanted item. Say, netherite chestpiece with unbreaking 3, prot 5, projectile prot 5, icy thorns, life mending 3, etc.
Step 2. Get a mending 1 book.
Step 3. Combine armor with mending 1 book at an anvil and pay 5 levels to "mend."
Step 4. Grab a book with another enchantment you would like to add to the original item. In this example lets grab an Unbreaking 3 book to combine with the armor which will make Unbreaking 4 on the armor.

If you would've done step 4 without doing steps 1 2 and 3, it would cost 247 levels.

If you do steps 1 2 and 3, and then do step 4, the enchantment combine will cost only 19 levels, as the armor is reset to base value +5 when using the mending book.

Now I'm not a coder and I'm not going to tell anybody how to do their job, but if I may make a suggestion without disabling mending 1 entirely, make it so Mending 1 books remove enchantments from armor when applied, to dissuade the level abuse while adding a situationally useful enchantment reset mechanic. A lore reason for it if necessary could be it using the latent magic in existing enchantments to fuel the repair process. I would say add a curse, but those are trivial to remove with prismatic webs.

■ Crash Report File and Logs

No response

commented

Additional info I would like to add is that this works in single player, private server, and the official Gothic Dragon Survival server.

commented

DS doesn't mess with enchantments in this way. This is a potential issue with the modpack maybe? But it doesn't have to do with our code.