[1.20.1 Bug]: Sea Dragon underwater Night Vision doesn't work with shaders present
Wakatsu opened this issue · 6 comments
■ Your Discord ID or other contacts
wakazu
■ Dragon Survival version
DragonSurvival-1.20.1-18.07.2024
■ Forge/Neoforge version
Forge 47.3.1
■ Single game or server?
Self-made dedicated server
■ Describe the bug
Night Vision straight up doesn't work. The mana is removed, the cooldown is applied, but nothing happens visually
■ Crash Report File and Logs
No response
Sildur's Enhanced Default v1.16 Fast and ComplementaryUnbound_r5.2.2
Tested with both, doesn't work
tested ComplementaryUnbound
lava vision does not really work as intended
- top layer is only very slighty translucent if at all
- submerged you get a bit better visibility but not much
- maybe make the visibility value configurable? unlikely that all shaders can be properly handled
water vision also doesn't work
- top layer is already very translucent so this one is okay, probably?
- no change when submerged, probably because of this: https://github.com/Asek3/Oculus/blob/7f2f97aa2c41b57e1759a23deccb4d4c2ad695ea/src/main/java/net/irisshaders/iris/uniforms/CommonUniforms.java#L292
- would recommend a mixin in game renderer that only applies if oculus is present (which returns a suitable scale but only if submerged and water vision is active)
- (this shader is using said variable in their lighting logic)
I don't think anything can be done for lava, it just depends on the used shader and the config they provide
With some you can see a bit better with lava vision and with others it's just full of bloom and oversaturated effects and whatnot