Draw Bridge

Describe the bug
using the drawerbridge, there is a slot for the block to render as another to blend in with the rest of your base, but as you can see if its not a full block it allows x-ray

Additionally, placing a complex block as the render block can crash you - It does with a Wire from the mod Silent Mechanisms. Crash-report at the bottom.

To Reproduce
Steps to reproduce the behavior:

Place Drawbridge
Give it a torch as a render item
See-through drawbridge

Expected behavior
For the Drawbridge to reject/not accept the item, or otherwise indicate that it should not be used. Maybe default to normal Drawbridge render.

Screenshots
Screenshot

Versions

Minecraft Version 1.14.4
Forge Version 28.1.39
UTeamCore Version 1.14.4-2.7.4.134

Log (if crash occures)
https://gist.github.com/NillerMedDild/9bbd31a0abf3aeea8374d42927659342

This shouldn't happen as you shouldn't be able to put in a torch in the first place in the first place.
I am investigating this.

Cheers
~MrTroble

This is a bug, that I have cause by not checking for the right properties.
Currently we only check if the block is solid:

Draw-Bridge/src/main/java/info/u_team/draw_bridge/tileentity/DrawBridgeTileEntity.java

Lines 35 to 42 in 9812869

    
           public boolean isItemValid(int index, ItemStack stack) { 
        
           	final Item item = stack.getItem(); 
        
           	if (!(item instanceof BlockItem) || item == DrawBridgeBlocks.DRAW_BRIDGE.asItem()) { 
        
           		return false; 
        
           	} 
        
           	final Block block = ((BlockItem) item).getBlock(); 
        
           	return block.getDefaultState().isSolid(); 
        
           }

This check is not enough. Dunno which method is better suited here.

I have already thought that this was an issue ... gonna change that

This should be fixed by now ... if this should reoccur please reopen

	public boolean isItemValid(int index, ItemStack stack) {
	final Item item = stack.getItem();
	if (!(item instanceof BlockItem) \|\| item == DrawBridgeBlocks.DRAW_BRIDGE.asItem()) {
	return false;
	}
	final Block block = ((BlockItem) item).getBlock();
	return block.getDefaultState().isSolid();
	}

Share to