Global Packs

Global Packs

18M Downloads

DRP can't override mod datapacks

Partonetrain opened this issue ยท 5 comments

commented

DRP-GDP doesn't seem to be able to override datapacks being added by other mods.

SilentGear adds its own datapack, like so: https://github.com/SilentChaos512/Silent-Gear/tree/1.14/src/main/resources/data
It also lets you change its datapacks with your own datapacks: https://github.com/SilentChaos512/Silent-Gear/wiki/Gear-Parts

However, I can't seem to override them using GlobalDataPacks, while the vanilla method of dropping the data pack in your save seems to work fine.

for example, placing a datapack using SilentGear's in my save works as intented, like so:
saves\t12\datapacks\testdata\data\silentgear\silentgear\parts\main\gold.json
but placing it in global_data_packs like this does not act the same:
global_data_packs\testdata\data\silentgear\silentgear\parts\main\gold.json

The datapack between the two folders is the same, .mcmeta and everything.

(May be an issue with silent gear, not sure)

commented

Hm... that will be difficult to figure out ๐Ÿค”
Sadly you can either put your datapack when adding it ingame to the bottom, or top.
Top would override datapacks that are in the world folder. Bottom has the issue you described.
But yes, I guess there will be less users adding custom data packs when they are using modpacks.
So I'll switch that. And hope that it does indeed override mod datapacks, as I have no Influence on the order this stuff get's loaded.

commented

Uploaded a new version https://www.curseforge.com/minecraft/mc-mods/drp-global-datapack/files/2781689 (waiting for approval at the time I am writing this)
hopefully it does fix this issue, I'd appreciate if you could test it.

commented

Unfortunately that seems to have broken it entirely :(
Got an warning on the title screen with this new version:
image

and datapacks in global_data_packs folder don't show up after using /datapack list

[had to edit because accidentally included my PC's username in screenshot, oops]

commented

Sometimes I hate my life ๐Ÿ™„
It took just 2 hours to find the issue, just another dumb copy paste issue xD
Fixed in 1.2.1

commented

Looks to work correctly now! Thank you.