Druidcraft

Druidcraft

8M Downloads

KNOWN ISSUE: Elder flowers have no texture.

toErIpNid opened this issue Β· 21 comments

commented

General Information

Describe the bug:
Elder flowers (the block) have no texture.

To Reproduce:

  1. Download Druidry.
  2. Create a new world.
  3. Look at an elder tree in all of its buggy glory.

Expected behavior:
I expected an actual texture.


Environment Versions

Mystic Mods Versions

  • MysticalLib:
  • Ecc...

Other Versions:

  • Conflicting mod (if regarding mod integration):
  • Other mods you think could cause issues:
  • Forge:
  • Minecraft:
  • Modpack (if available):

Logging Information

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available):

Latest Log (if necessary):


Additional Information

Screenshots (if available):

Additional context (optional):

commented

I am using the Lennbain modpack and ran into the same problem while I was recording a video earlier.

2021-09-10_11 29 54

commented

Me too,same problem.
Snipaste_2021-09-11_05-59-58
Snipaste_2021-09-11_06-00-21

commented

What version of Druidcraft is this with?

commented

Ah, Lennbain appears to be the latest version. I'll try to fix that today.

commented

Oh, someone already reported this.
I just encountered it too and was about to mention it.
Awesome mod though, thanks for your work!

commented

Found the issue, you capitalized the final letters in the .png files/models for the leaves and you didnt update the model files to reflect this.

commented

Elder Leaves should have the same problem, capitalized A/B/C in png, not in json

commented

I'm hoping to release .45 soon to fix this, but at the same time there are some other issues I need to fix first.

commented

This one is not "really" an issue, as it can be fixed relatively easily by the user, just by finding the uppercased file and renaming them, so no rush I think lol

commented

I noticed the same issues and the same source of the problem of capital letters as mentioned. I was able to circumvent the problem using a texture pack override copying the model files and texture files from the assets pertaining to the elder_fruit and changing the capital A, B, C at the ends with lower case letters. This corrected the problem, at least until an update is released. In my case I utilized the Kubejs assets override folder, but I imagine one can set a custom texture pack folder in the resources folder to the same effect as long as it is then enabled in the options interface.

commented

Was just about to report this one myself, but it appears you are already on it, look forward to the next update, thanks for all your hard work.

commented

I was gonna report this but i think it's already covered

commented

Appears to still be a problem, even with the case of the texture files changed to lower case.

https://i.imgur.com/vtIITfd.png

commented

Confirmed the issue is present in 0.4.53 but not 0.4.52.

commented

SargeRyong, here is a listing of files that need name changes that effect the elder fruit. I have not yet looked at the other textures myself.
assets/druitcraft/models/block/
elder_fruit_stage0a.json
... (yes, I concatenated the intervening for brevity, stages 0-5 and ABC are all included)
elder_fruit_stage5c.json
assets/druitcraft/textures/block/
elder_fruit_leavesa.png
elder_fruit_leavesb.png
elder_fruit_leavesc.png

These are the files that need changing to lower case.
I traced them through the blockstates/elder_fruit.json file which first references the lowercase abc models.

commented

Have the problem in 4.53 , Reverting back to 4.52 seems to have fixed it

commented

I'm hoping to release .45 soon to fix this, but at the same time there are some other issues I need to fix first.

... (discussion of delay)

AngleWyrm β€” Today at 3:47 PM
Apparently the author doesn't consider it worth a hotfix: "I'm hoping to release .45 soon to fix this, but at the same time there are some other issues I need to fix first." #136 (comment)

... (question is asked if there are downsides to doing hotfixes)

AngleWyrm β€” Today at 3:54 PM
None that I'm aware of; seems to me a new version release would promote more downloads. It's just pushing an update to github and posting to CurseForge, isn't it? So it looks psychological to me, like part of the five stages of grief -- Denial, Anger, Bargaining, Depression, Acceptance -- where it's currently at the Bargaining phase

...

[EDITED BY ADMINISTRATOR: It's unfair to quote people out of context, especially without their permission.]

commented

Personally, when I have a fixable issue that I know is on the back burner, I hotfix it myself while I wait. This looks trivial to fix from a modpack author's perspective. Multiple people have mentioned what needs to be done to hotfix the issue, so I am surprised no one has just made one yet.

Anyway, I'm not sure if it's really worth anyone's drama as to why a hotfix wasn't made yet. Let's try and keep it civil here, shall we?

commented

@AngleWyrm10 To start with, I'm not the author of the mod, I'm merely a contributor.

I released this version because specific interactions with crates were causing crashes that were unrecoverable and required people to manually delete blocks from the world; I had no idea that it broke elderflowers until I was well into making modifications to try to fix other bugs (such as hemp breaking through bedrock, not being able to control the spawn of lavender, not being able to control the spawn of beetles, etc).

Since then, I've been dealing with a huge amount of real life stress, and this ceased to be a huge priority for me. I'm sorry that you find it so distressing.

That said, anyone who is willing could look at the "crate_fix" branch (which the most recent build was built off) and create a PR to that branch fixing the relevant files. I could accept the PR and do a release.

I find your tone and your comment, surprisingly, does not encourage me to want to work on this mod further, and that it actually increases my stress.

commented

So, if anyone's interested: this issue stems from the fact that both Git and the resultant .jar file care about file-system name casing. On the other hand, Windows 10 does not: this means that the relevant files were checked out in all lower case for some reason on my system.

While I will be releasing a fix for it shortly (I had to delete, commit, then re-add the textures with lower case file names for it to actually pick up that I had changed the case of them), the entire issue has left a very sour taste in my mouth,. I was almost inclined not to release it just out of spite, but I figured that would be hurtful to all the people who were waiting patiently without complaining.

commented

SargeRyong, here is a listing of files that need name changes that effect the elder fruit.
I have not yet looked at the other textures myself.

  • assets/druitcraft/models/block/
  • elder_fruit_stage0a.json ...
  • (yes, I concatenated the intervening for brevity, stages 0-5 and ABC are all included)
  • elder_fruit_stage5c.json
  • assets/druitcraft/textures/block/
  • elder_fruit_leavesa.png
  • elder_fruit_leavesb.png
  • elder_fruit_leavesc.png

These are the files that need changing to lower case. I traced them through the blockstates/elder_fruit.json file which first references the lowercase abc models.

This worked perfectly, thank you!

Fix