Dungeon Mobs Reborn

Dungeon Mobs Reborn

556k Downloads

Blade Trap is missing mapping+causes crash upon world creation

Nat-cha034 opened this issue ยท 8 comments

commented

Just downloaded the newest version of the mod last night, & upon attempting to load a new world with it, MC froze upon world creation & then crashed, according to the crash log, this is due to the Blade Trap missing a mapping:

https://paste.dimdev.org/xudakoxihu.rb

commented

The code does not seem to have changed from the previous version.

commented

It looks like I'm also able to corroborate this, as my Minecraft is crashing related to Blade Traps with the exact same prompt as Nat-cha034.

In addition, it looks like the log gets spammed with this prior to crashing:

[17:06:48] [Server thread/ERROR] [FML]: A TileEntity type com.gw.dm.blocks.TileEntityBladeTrap has throw an exception trying to write state. It will not persist. Report this to the mod author
java.lang.RuntimeException: class com.gw.dm.blocks.TileEntityBladeTrap is missing a mapping! This is a bug!
	at net.minecraft.tileentity.TileEntity.writeInternal(TileEntity.java:78) ~[avj.class:?]
	at net.minecraft.tileentity.TileEntity.writeToNBT(TileEntity.java:69) ~[avj.class:?]
	at com.gw.dm.blocks.TileEntityBladeTrap.writeToNBT(TileEntityBladeTrap.java:192) ~[TileEntityBladeTrap.class:?]
	at net.minecraft.world.chunk.storage.AnvilChunkLoader.writeChunkToNBT(AnvilChunkLoader.java:383) [aye.class:?]
	at net.minecraft.world.chunk.storage.AnvilChunkLoader.saveChunk(AnvilChunkLoader.java:174) [aye.class:?]
	at net.minecraft.world.gen.ChunkProviderServer.saveChunkData(ChunkProviderServer.java:202) [on.class:?]
	at net.minecraft.world.gen.ChunkProviderServer.saveChunks(ChunkProviderServer.java:230) [on.class:?]
	at net.minecraft.world.WorldServer.saveAllChunks(WorldServer.java:1007) [oo.class:?]
	at net.minecraft.server.MinecraftServer.saveAllWorlds(MinecraftServer.java:408) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.saveAllWorlds(IntegratedServer.java:376) [chd.class:?]
	at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:446) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.stopServer(IntegratedServer.java:515) [chd.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:579) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_271]
commented
commented

I'll see when I can get to this.

commented

OK, it's not just the tile entity for blade traps, it's all blocks, tile entities, and items in the mod. It looks like the real underlying error is this:

[21:35:37] [Client thread/WARN] [FML]: ****************************************
[21:35:37] [Client thread/WARN] [FML]: * Could not determine owning mod for @EventBusSubscriber on com.gw.dm.util.MiscRegistrar for mod dungeonmobs
[21:35:37] [Client thread/WARN] [FML]: *  at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:71)
[21:35:37] [Client thread/WARN] [FML]: *  at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:601)
[21:35:37] [Client thread/WARN] [FML]: *  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[21:35:37] [Client thread/WARN] [FML]: *  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[21:35:37] [Client thread/WARN] [FML]: *  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[21:35:37] [Client thread/WARN] [FML]: *  at java.lang.reflect.Method.invoke(Method.java:498)...

It looks to me like Forge changed something in how the registrations work since the initial 1.12.2 update was made, so the existing code no longer works. I have no idea how registration are supposed to be set up now (i.e., how to fix it).

commented

OK, it looks like it just need the mod id in the event subscription to work; it should be fixed now (well, as soon as I compile and upload, I may check to make sure the fixes in the last patch are there in what I currently have).

commented

OK, the problem seems to be fixed in the new patch, version 5.8.8.

commented

That's very strange, since blade traps were not changed! I'll see if I can take a look next week; sorry, can't do it today.