Dungeons Gear

Dungeons Gear

6M Downloads

[1.16.3] Crash when Resourceful Bees mod is present

bessiq opened this issue · 3 comments

commented

Forge: 34.1.25
Resourceful Bees 1.16.3-0.5.5b (and 2 previous versions)
dungeons_gear-1.16.2+1.16.3-2.0.12.jar (and several previous versions)
logs: https://gist.github.com/bessiq/4530d87371be852324d74493fbd9d28b

Not sure which mod is at fault, as both mods work fine if the other is not enabled. I thought I'd post here first to see what you think. Basically, the game crashes during Forge early loading when these two mods are enabled together. I know you recently added some kind of bee functionality, which I assume might be conflicting with something RBees is trying to do.

Thanks for any help you can provide.

commented

This is their fault. They access transformed a method called alertOthers in an AI class called HurtByTargetGoal, which all mobs that attack when provoked use, from protected to public. As I use a mixin for the same class to fix a glaring error inside that method, the mod loader complains that I am making a public method protected in my mixin when I am using the same access level it originally has because Resourceful Bees made it public with their access transformer.

They should reduce their access transform usage in general to prevent problems like this. It is especially heinous in this case as that method doesn’t need to be access transformed in the first place.

commented

Thanks for the reply. I am going to open an issue with them and reference this issue to save some typing if that's cool.

commented