Dungeons Enhanced

Dungeons Enhanced

17M Downloads

Structure spacing offset not applied correctly

Gbergz opened this issue ยท 22 comments

commented

Right now structures of different types can spawn ontop of each other and super close to each other making them not that rare even if seperate spacing and rarity is turned up.

Images:
image
2022-01-19_01 00 30

- Gbergz

commented

scratch that, it looks like overlap can still happen occasionally outside of spawn:
2022-02-20_02 00 26

commented

It looks like this issue is still persisting as of the latest update in one last way, and that's how dungeon overlap now only seems to happen at world spawn, sometimes with other modded dungeons and vanilla ones too:
2022-02-19_04 07 53
2022-02-19_04 09 54
2022-02-19_04 12 25
(they also sometimes don't overlap and just mean you get a nice set of dungeons to loot pretty much immediately at spawn, which is kinda nice if you ask me, but usually you get some mess like seen above)

I've also noticed that the ice pit dungeon seems to generate much deeper than it should, or at least noticed that happen once:
2022-02-19_03 56 58

in any case, it's good to see that I otherwise won't be experiencing dungeon overlap as I had back in 1.16 versions of this mod, so cheers to that at least!

commented

it'll be fixed in beta 3, which hasn't yet been released

commented

next beta is out, hopefully it's now fixed

commented

Sorry to say, but does not seem to be fixed:
2022-02-23_19 21 33
And there are sometime still weird rough borders:
2022-02-23_19 21 46

commented

have you deleted you config? I'm pretty sure that the spreading is fixed.
If not please give me seed and coords

yea, the borders are the next problem I have to fix

commented

Yes, removed the config and seems to work fine now, thanks!

commented

With the 1.3 update every problem related to this should be fixed. this seems more like a bug to me. Can you provide more information (MC version, Forge version, Mod version, in case other mods you have installed)?

commented

MC: 1.18.1
Forge: 39.0.36
DungeonsEnhanced: 3.0b1 on CF | filename: dungeons_enhanced-1.18.1-3.0-BETA | https://www.curseforge.com/minecraft/mc-mods/dungeonsenhanced/files/3608281

Structure Gel API: 2.1.1 | https://www.curseforge.com/minecraft/mc-mods/structure-gel-api/files/3600725

Modpack is Limitless 5, but I've not added the mod yet. But the modlist is basically the same as this version: (Scrolldown)
https://www.curseforge.com/minecraft/modpacks/tnp-limitless-5/files/3607080

commented

No rush, just wondering if this new update will be out today or another day. Gonna publish an update to Limitless 5 and pondering on whether I should include this version of the mod since the placement of the structures are weird atm.

commented

Guess you have to wait until a stable version of Dungeons Enhanced is out before you can include it. The problem could also be on forge side but I need to analyse this problem further. Anyway thanks for wanting to include us!

commented

Can confirm,
2022-01-20_11 52 09
2022-01-20_11 58 30
2022-01-19_14 30 07
Espacially the last one, the structures should verify if they are underground, because here it's reaaaaaally weird x)
Some structures should spawn columns of cobblestone (like the woodland mansion in vanilla) when generating, like the castle etc., so they don't float or float with an island under them.

commented

thanks for your images! this is not related to this issue (sorry for the unclear title). You don't have to create a new one, most of the problems you showed are already fixed in the next Update

commented

hopefully fixed in the next beta

commented

Try updating Structure Gel. They fixed a few issues that could affect this issue.

commented

Try updating Structure Gel. They fixed a few issues that could affect this issue.

Will do.

commented

Seems to be working better. (I think atleast). Although structure placement seems a bit rough. (Edit: Like reported above. Oops.)
image

commented

yea, wait for the next update. It should fix most of the placement issues

commented

update is out. It fixes almost everthing in this issue.

commented

I'll create a new issue with the remaining issues

commented

Update on this. Spacing between each structure seems to be an issue still. got 5 structures spawning super close to eachother. Like ontop aswell.
image

A Tower of the Undead, Ruined Building, Stables, Pillager Camp & a Druid Circle.

Edit: (2nd Image)
image

Versions:

Minecraft: 1.18.1
Forge: 39.0.64
Dungeons Enchanced: 3.0b2 | https://www.curseforge.com/minecraft/mc-mods/dungeonsenhanced/files/3633941
Structure Gel API: 2.1.3 | https://www.curseforge.com/minecraft/mc-mods/structure-gel-api/files/3629303

Edit: This was on the initial spawn point, right ontop.

commented

yes, I heard it a few times now. I guess now I know what went wrong but I hadn't enought time to fix it. Hope I manage to solve it in the next days.