Dye Depot

Dye Depot

51.9k Downloads

Crash with MoreSnifferFlowers mod

Closed this issue ยท 4 comments

commented

What happened?

When I middle-mouse click certain coloured Vivicus Saplings (and likely leaves and logs) the game crashes. This seems to be caused by the MoreSnifferFlowers mod assuming only the 16 vanilla colours when constructing its own internal mapping from dye colour to colour value.

Map construction code here: https://github.com/Nikdo53/MoreSnifferFlowers/blob/1b72e1375d3a7ab572fce21408518d2e957f0748/src/main/java/net/abraxator/moresnifferflowers/blocks/ColorableVivicusBlock.java#L71-L91

Place where map is used: https://github.com/Nikdo53/MoreSnifferFlowers/blob/1b72e1375d3a7ab572fce21408518d2e957f0748/src/main/java/net/abraxator/moresnifferflowers/mixins/BlockMixin.java#L30

Mod Version

dye_depot-1.2.1-forge

Minecraft Version

1.20

log output

https://mclo.gs/CvB2mRU

commented

Just wanted to let @Nikdo53 be aware of this

commented

I fixed this on my side so you can close the issue, btw I dont think theres much the dye depot devs couldve done so just report it to the guilty devs next time

commented

@Nikdo53 thank you very much, that's great to here.
Then I will close the issue here

commented

I fixed this on my side so you can close the issue, btw I dont think theres much the dye depot devs couldve done so just report it to the guilty devs next time

I wasn't really sure where to report it since Dye Depot is technically the guilty party since they break the assumption of 'only' 16 dyes. Either way, nice of you to fix it! :D