Dynamic Darkness

Dynamic Darkness

Mods
236k Downloads

Poor performance past 0.2.1

TheComputerizer opened this issue · 4 comments

commented

I really should have reported this a while back when I noticed that, but I have been using darkness-0.2.1-all for a while instead of the newer versions due to every version past 0.2.1 cutting my FPS in half.

I decided to do a direct FPS comparison between darkness-0.2.1-all, darkness-forge-1.12.x-0.4.2, and Hardcore Darkness and here are the results of that.

Unfortunately my FPS on latest version of this is still very bad.

Here is my modpack if you would like the list of mods. I am using the latest forge version of 14.23.5.2860

commented

I did some spark profiling for 0.2.1 and 0.4.2 and something weird is definitely going on.

Here is the 0.2.1 profile and here is the 0.4.2 profile

Whatever the method io.github.yamporg.darkness.asm.EntityRendererHooks.updateLuminance() is taking up over 50% of the client thread in 0.4.2 which would account for my FPS getting cut in half

commented

Seems to be an issue with mod compatibility and hook injection logic. Currently the hook can potentially be injected at multiple points if other coremods insert net.minecraft.client.renderer.texture.DynamicTexture updateDynamicTexture calls in net.minecraft.client.renderer.EntityRenderer updateLightmap.

mods/darkness-forge-1.12.x/src/main/java/io/github/yamporg/darkness/asm/EntityRendererTransformer.java

Lines 45 to 86 in 8ee0a09

cr.accept(
new ClassVisitor(Opcodes.ASM5, cw) {
@Override
public MethodVisitor visitMethod(
int access,
String name,
String desc,
String signature,
String[] exceptions) {
MethodVisitor mv =
super.visitMethod(access, name, desc, signature, exceptions);
if (!UPDATE_LIGHTMAP_NAME.equals(name)
|| !UPDATE_LIGHTMAP_DESC.equals(desc)) {
return mv;
}
return new GeneratorAdapter(api, mv, access, name, desc) {
@Override
public void visitMethodInsn(
int opcode,
String owner,
String name,
String desc,
boolean itf) {
if (!itf
&& Opcodes.INVOKEVIRTUAL != opcode
&& !UPDATE_DYNAMIC_TEXTURE_OWNER.equals(owner)
&& !UPDATE_DYNAMIC_TEXTURE_NAME.equals(name)
&& !UPDATE_DYNAMIC_TEXTURE_DESC.equals(desc)) {
loadThis();
loadArgs();
invokeStatic(
Type.getObjectType(ENTITY_RENDERER_HOOKS),
new Method(
ON_UPDATE_LIGHTMAP_NAME,
ON_UPDATE_LIGHTMAP_DESC));
}
super.visitMethodInsn(opcode, owner, name, desc, itf);
}
};
}
},
ClassReader.SKIP_FRAMES);

commented

@TheComputerizer I've published v0.5.0 release with the fix, let me know if the issue is still relevant for you.

commented

Hey @tie:

I have had this issue in the past as well. In my testing with darkness-forge-1.12.x-0.5.0.jar, I have found the issue is no longer relevant. My FPS (when set to unlimited) is upwards of 140, as opposed to 20 fps like it was before.

  • 👍1