New Version(unsure what version) Incompatible with Fastload
aaron01-dev opened this issue · 5 comments
So I updated DynamicFPS today, it worked when I played MC with v2.2.0 I also downgraded to v3.0.0 and it seems it's still incompatible, downgrading back to v2.2.0 and it didn't lead to loading screen lock,
Steps to Reproduce:
- Install Fastload and DynamicFPS(v3 and above) (including dependencies of course)
- Load a world or join a server
- Stuck in loading screen
It seems Fastload is no longer maintained but the latest version it has is from May, and since DynamicFPS updated last, I figured to add an issue here.
Okay ignore the old comment, I tested on 1.20.1 and things seemed fine there, I can reproduce this on 1.19.2.
Well questionable decisions aside, the reason this breaks is that Dynamic FPS will skip rendering the world while the loading overlay or an opaque screen is currently overlaid over the world (e.g. when you have switched resource packs, or are in any screen with the dirt background) to help with performance on lower end systems.
Usually this optimization also breaks the vanilla loading screen, but we disable this optimization specifically for it:
Dynamic-FPS/src/main/resources/fabric.mod.json
Lines 62 to 64 in d9b700a
I can create a PR for Fastload to also fix this with their loading screen, but since their project is inactive at this time I doubt it would get accepted in a timely manner. If you (or anyone else) would like to use these mods together you can add this to your mods folder, it will simply ask Dynamic FPS to not optimize Fastload's loading screen.
https://files.lostluma.net/dynamic-fps-fastload-fix.jar (don't delete Dynamic FPS, just add this mod)
If you're curious what this does you can open and inspect it, it just contains a very small fabric.mod.json file and no code at all.